Skip to content

Fix blob URL handling for large messages with special characters in instanceId - #1204

Merged
Naiyuan Tian (nytian) merged 7 commits into
mainfrom
nytian/blob-url-encode
Apr 23, 2025
Merged

Naiyuan Tian (nytian) merged 7 commits into
mainfrom
nytian/blob-url-encode

Conversation

@nytian

@nytian Naiyuan Tian (nytian) commented Apr 22, 2025 •

Copy link
Copy Markdown
Contributor

When the instanceId contains special characters like '|',' :', or spaces, the generated blob URL becomes invalid because these characters are not allowed unescaped in a URI. This results in the orchestrator returning a blob URL instead of the expected large message content. This PR fixes it by escaping invalid characters when constructing the blob URL.

Solves Azure/azure-functions-durable-extension#3010

@cgillum

Copy link
Copy Markdown
Member

Naiyuan Tian (@nytian) looks like the LargeOverallTextMessagePayloads_BlobUrl test is failing.

@nytian
Naiyuan Tian (nytian) marked this pull request as draft April 23, 2025 03:37
@nytian
Naiyuan Tian (nytian) marked this pull request as ready for review April 23, 2025 04:33
@nytian
Naiyuan Tian (nytian) merged commit 463c052 into main Apr 23, 2025
@nytian
Naiyuan Tian (nytian) deleted the nytian/blob-url-encode branch April 23, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants