Feature/Add JMX metrics #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/main/java/com/microsoft/azure/kusto/kafka/connect/sink/FileWriter.java:235
- Verify that incrementing purgedOffset by the current value of flushedOffset is intentional; using a cumulative counter value may lead to misleading metric results.
purgedOffset.inc(flushedOffset.getCount());
src/main/java/com/microsoft/azure/kusto/kafka/connect/sink/TopicPartitionWriter.java
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/kusto/kafka/connect/sink/FileWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/kusto/kafka/connect/sink/KustoSinkTask.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/kusto/kafka/connect/sink/FileWriter.java
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/kusto/kafka/connect/sink/FileWriter.java
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/kusto/kafka/connect/sink/metrics/KustoKafkaMetricsUtil.java
Show resolved
Hide resolved
monishkadas-ms
had a problem deploying
to
build
GitHub Actions
Failure
monishkadas-ms
had a problem deploying
to
build
GitHub Actions
Failure
tanmaya-panda1
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configures custom JMX Metrics