-
Notifications
You must be signed in to change notification settings - Fork 46
Edge TB: Expose WebApps APIs, Fixes AB#3409879 #2793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for WebApps APIs in the Edge Token Broker by adding two new broker operations: getSupportedWebAppContracts and executeWebAppRequest. These operations enable the broker to expose WebApps functionality through the existing broker protocol infrastructure.
Key Changes
- Added new broker protocol constants for WebApps API communication (request/response/error keys)
- Implemented two new broker operations in
BrokerMsalControllerfor getting supported contracts and executing web app requests - Added corresponding adapter methods for bundling requests and extracting results from broker responses
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AuthenticationConstants.java | Defines new broker protocol constants for WebApps API keys (contracts, request, response, error) |
| MsalBrokerRequestAdapter.java | Adds methods to construct request bundles for getSupportedWebAppContracts and executeWebAppRequest operations |
| MsalBrokerResultAdapter.java | Implements result extraction methods for WebApps operations with null-safety checks |
| BrokerMsalController.java | Implements the two main WebApps broker operations following the existing broker operation pattern |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary:
In this PR, we:
Related broker PR: https://github.com/AzureAD/ad-accounts-for-android/pull/3256
AB#3409879