Skip to content

Structure_Engine: Add support for ConnectionForce fragments and refactor takeoffs - #3608

Open
IsakNaslundBh wants to merge 23 commits into
developfrom
Structure_oM-#3607-AddConnectionAllowanceFragment
Open

Structure_Engine: Add support for ConnectionForce fragments and refactor takeoffs#3608
IsakNaslundBh wants to merge 23 commits into
developfrom
Structure_oM-#3607-AddConnectionAllowanceFragment

Conversation

@IsakNaslundBh

@IsakNaslundBh IsakNaslundBh commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

NOTE: Depends on

BHoM/BHoM#1732

Issues addressed by this PR

Closes #3607

Change methodology for extracting materiality from structural elements from using the MaterialComposition to instead make use of the GeneralMaterialTakeoff method.

Gives better flexibility in quantities returned and also makes the addition of connectionallowance more straightforward

Test files

See:
BHoM/BHoM#1732

Changelog

Additional comments

Change methodology for extracting materiality from structural elements from using the MaterialComposition to instead make use of the GeneralMaterialTakeoff method.

Gives better flexibility in quantities returned and also makes the addition of connectionallowance more straightforward
@IsakNaslundBh IsakNaslundBh self-assigned this Sep 1, 2026
@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Sep 1, 2026
Piles where not handling ReinforcementDensities befoew and were hence giving errors. This has been amended in this testfile. Appart from that, the file runs as expected with the previous methods
Was failing due to change in order of materials of new methods. Now the reinforcement is always applied last which was not the case before, especially not for topped slabs.
@IsakNaslundBh

Copy link
Copy Markdown
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci

bhombot-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

There are 39 requests in the queue ahead of you.

…ies and toplevel reinforcementdensity being applied to non-concrete piles for PileFOundation
@IsakNaslundBh
IsakNaslundBh marked this pull request as ready for review September 2, 2026 11:43
@bhombot-ci

bhombot-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on StructuralEngineering_Toolkit

@IsakNaslundBh

Copy link
Copy Markdown
Contributor Author

@BHoMBot check unit-tests
@BHoMBot check dataset-compliance

@bhombot-ci

bhombot-ci Bot commented Sep 7, 2026

Copy link
Copy Markdown

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests
  • check dataset-compliance

There are 14 requests in the queue ahead of you.

@IsakNaslundBh

Copy link
Copy Markdown
Contributor Author

@BHoMBot check unit-tests
@BHoMBot check dataset-compliance

@bhombot-ci

bhombot-ci Bot commented Sep 7, 2026

Copy link
Copy Markdown

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests
  • check dataset-compliance

There are 9 requests in the queue ahead of you.

@peterjamesnugent peterjamesnugent left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on the code, nothing major. I can do some testing with the script tomorrow - had a brief look at it and looks good.

Comment thread Structure_Engine/Query/SolidVolume.cs Outdated
Comment thread Structure_Engine/Query/SolidVolume.cs Outdated
Comment thread Structure_Engine/Query/SolidVolume.cs Outdated
Comment thread Structure_Engine/Query/SolidVolume.cs Outdated
Comment thread Structure_Engine/Query/SolidVolume.cs Outdated
Comment thread Structure_Engine/Query/GeneralMaterialTakeoff.cs Outdated
Comment thread Structure_Engine/Query/GeneralMaterialTakeoff.cs Outdated
Comment thread Structure_Engine/Query/GeneralMaterialTakeoff.cs Outdated
Comment thread Structure_Engine/Query/GeneralMaterialTakeoff.cs Outdated
Comment thread Structure_Engine/Query/MaterialComposition.cs
IsakNaslundBh and others added 2 commits September 9, 2026 08:58
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
@IsakNaslundBh

Copy link
Copy Markdown
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci

bhombot-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

There are 22 requests in the queue ahead of you.

@IsakNaslundBh

Copy link
Copy Markdown
Contributor Author

THanks for the review @peterjamesnugent .

THink I have adressed all of your comments - this should be good to go now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New capability or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Structure_Engine: Refactor takeoffs for elements to use the GeneralMaterialTakeoff

2 participants