Enable sanitizers for macOS, Linux #1559
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
something I ran into 5 years ago that's still a big challenge: getting ASan to run on Android simulator/device is very very finicky. If you manage to figure it out, it would be a huge help! :D if that's what you get stuck on, then I'd say that getting v8 integration coverage on a non-Android platform could be a good fallback that would likely give the effectively the same feedback loop. |
Contributor
Author
|
@matthargett I think you are referring to ASAN images not available and missing .so :) |
…nto ASAN # Conflicts: # Polyfills/Canvas/Source/Gradient.cpp
CedricGuillemet
changed the title
matthargett
reviewed
Nov 15, 2025
| void Clear() { stackElements.clear(); } | ||
| void Clear() | ||
| { | ||
| stackElements = std::vector<StackElement>(); // deallocate memory |
There was a problem hiding this comment.
Is this a placement new of the existing stack allocation for the object? does it actually safely clear the heap-allocated internal members without introducing a leak?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Address sanitizer as pointed by #1557