fix: handle non-table profiles in config.load

[omerozku]

Summary

Fixes AttributeError: 'str' object has no attribute 'items' when profiles key in TOML config is a string instead of a table.

Problem

config.load() crashes when encountering valid TOML files like:

profiles = "mistake"

or:

[profiles]
default = "mistake"

Solution

Added validation in load() to check that:

1. The profiles key is a dict (table), not a string or other scalar
2. Each profile value is a dict (table), not a string

When validation fails, returns a Config with load_error set instead of crashing.

Testing

Added test_config_fix.py with tests for:

• String profiles value
• Nested string profile value
• Valid profiles still work
• Missing profiles section loads normally

Fixes #13340

[cubic-dev-ai]

All reported issues were addressed across 2 files

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[Git-on-my-level]

Thanks for the clean fix — this addresses #13340 well and the quality bar is high.

sdks/python-cli/omi_cli/config.py — the two isinstance checks in load() guard exactly the crash path from the issue: 'profiles' being a scalar and a profile value being a scalar both now return a Config with load_error set instead of raising AttributeError in Profile construction. This slots nicely into the existing error model: like malformed TOML, the file is reported via load_error, which also means save() keeps refusing to overwrite a hand-repairable config. Error messages naming the offending key and type ('profiles', "profile 'default'") are helpful. (Two blank lines carry trailing whitespace — cosmetic only.)

sdks/python-cli/tests/test_config.py — the four regression tests are placed where pytest actually collects (testpaths = ["tests"]), reuse the conftest config_path fixture for isolation, and cover both repro shapes from the issue plus the two controls (valid profile loads; missing profiles section with a non-default active_profile still resolves). Good response to the earlier review note about the uncollected root-level test file.

One tiny doc nit: the PR description still says tests were added as test_config_fix.py, but they now live in tests/test_config.py — worth updating the Testing section so future readers aren't confused.

No CI runs are visible on this head yet; the tests should cover it once it runs. Leaving for routine human maintainer review before merge — nice first contribution.

---

by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with need human response.

[kodjima33]

Bug fix, confidence ~4-5/5: stated root cause (AttributeError when 'profiles' TOML key is a string/scalar), linked fixes #13340, scoped diff (57 lines/2 files), tests added for 4 scenarios, cubic-dev-ai review confirms all issues addressed. CI hasn't triggered yet (pending/no-checks, acceptable per hard floor) — first PR from this contributor.