Skip to content

Conversation

@aaravgarg
Copy link
Collaborator

  • there was a delay after clicking button to turn off and seeing led actually get turned off and feeling the haptic - removed this
  • removed led startup sequence since it was redundant and provides no value to the user

@aaravgarg aaravgarg requested a review from beastoin October 31, 2025 03:49
@aaravgarg aaravgarg requested review from beastoin and removed request for beastoin October 31, 2025 03:52
@beastoin
Copy link
Collaborator

beastoin commented Oct 31, 2025

keep all the delay values; these values help stabilize the device on turning on / off.

for the ux, you can change the order of these steps, like when turning off: play the haptic > turn the led off > do the rest, whatever, but pls keep all the delay values.

@aaravgarg

@aaravgarg
Copy link
Collaborator Author

noted, thanks!

@aaravgarg
Copy link
Collaborator Author

@beastoin fixed, pls check now thanks

@beastoin
Copy link
Collaborator

beastoin commented Nov 5, 2025

the code looks good btw i cannot merge if the pr is not tested. can you share with me the video of how it works?

also, why should we disable this?

Screenshot 2025-11-05 at 09 56 06

@aaravgarg
Copy link
Collaborator Author

the code looks good btw i cannot merge if the pr is not tested. can you share with me the video of how it works?

also, why should we disable this?

Screenshot 2025-11-05 at 09 56 06

its unnecessary; user expects to turn on as soon as possible

also let me attach that demo for u mb

@aaravgarg
Copy link
Collaborator Author

trim.21E4DA44-DB9E-4304-8FD0-7C68B43FC354.MOV

@aaravgarg
Copy link
Collaborator Author

@beastoin here you go; startup is simple; shut down is instant; delays maintained for stability (just the user doesn't see them for smooth experience)

@beastoin beastoin merged commit 15e431e into main Nov 10, 2025
1 check passed
@beastoin beastoin deleted the button-delay-fix branch November 10, 2025 09:43
@beastoin
Copy link
Collaborator

lgtm @aaravgarg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants