Conversation
Greptile SummaryThis PR simplifies the onboarding knowledge-graph hint footer by removing the timed flash/hover-reveal state machine (
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Graph data arrives] --> B[handleGraphDataArrival]
B --> C[graphHasData = true\n easeIn 0.35s]
C --> D[DispatchQueue delay 1.4s]
D --> E[showTrustPreview = false\n easeInOut 0.45s]
E --> F{graphHasData && !showTrustPreview}
F -->|true| G[Graph view visible\n transition .opacity]
F -->|true| H[Top label visible\n transition .opacity]
F -->|true| I[Hints footer visible\n animation easeInOut 0.3s]
F -->|false| J[All three hidden / trust card shown]
Last reviewed commit: 8899fb9 |
| .animation(.easeInOut(duration: 0.3), value: graphHasData) | ||
| .animation(.easeInOut(duration: 0.3), value: showTrustPreview) |
There was a problem hiding this comment.
Animation duration mismatch with trust-preview transition
The hints footer uses a 0.3s animation keyed on showTrustPreview, but the trust preview card itself is dismissed with withAnimation(.easeInOut(duration: 0.45)) (see handleGraphDataArrival). Because view-level .animation(_:value:) takes precedence over the enclosing withAnimation block for this modifier, the hints will reach full opacity about 150 ms before the trust card finishes fading out, making them briefly visible while the trust card is still on screen.
For a seamless cross-fade, align the duration with the dismissal animation:
| .animation(.easeInOut(duration: 0.3), value: graphHasData) | |
| .animation(.easeInOut(duration: 0.3), value: showTrustPreview) | |
| .animation(.easeInOut(duration: 0.3), value: graphHasData) | |
| .animation(.easeInOut(duration: 0.45), value: showTrustPreview) |
Summary
Verification
USAGE: agent-swift
OPTIONS:
--version Show the version.
-h, --help Show help information.
SUBCOMMANDS:
doctor Check prerequisites and diagnose issues
connect Connect to a macOS app
disconnect Disconnect from the connected app
status Show connection status
snapshot Capture element tree with refs
press Press element by ref
fill Enter text into element by ref
get Read element property by ref
find Find element by locator
screenshot Capture app screenshot
is Assert element condition
wait Wait for condition or delay
scroll Scroll by direction or element ref
click Click element or coordinates via CGEvent
schema Show command schema
See 'agent-swift help ' for detailed help. that , , and were still present after 7 seconds