Fix json schema validation

[EmmanuelVella]

Currently Sanpi\Behatch\Json\Json and ```Sanpi\Behatch\Json\JsonSchemaobjects are given to theJsonSchema\Validator::check` method.

It think this is incorrect as it should be the content value of this objects that should be used.

This PR fixes this.

[sanpii]

It think this is incorrect as it should be the content value of this objects that should be used.

This is done by the __toString method. I prefer this solution instead of expose the content attribute.

[EmmanuelVella]

Ok. However, it currently doesn't work. I will take time to find another solution.

[sanpii]

However, it currently doesn't work.

I have no error with the current test suite. Have you an example?

[EmmanuelVella]

In my project it doesn't throw errors even if there are some (for ex if a required field is missing).

[EmmanuelVella]

Let me take a look again, i will give you more details asap ;)

[EmmanuelVella]

At this point https://github.com/justinrainbow/json-schema/blob/1.3.7/src/JsonSchema/Constraints/Undefined.php#L119 the schema object I have is equal to someting like that :

Sanpi\Behatch\Json\JsonSchema {
  content: {
    "type": "object"
    "$schema": "http://json-schema.org/draft-03/schema"
    "required": true
    "properties": {
      "id": {
        "type": "integer"
        "required": true
      }
   ...

$schema->required is not defined, so it doesn't validate the required properties.

[sanpii]

"required": true

required is a array of required properties: http://json-schema.org/examples.html

[EmmanuelVella]

Ho ok, I will update it. However, it's still not accessible, as it's a child of the content attribute !

[stephpy]

👍 , i'm having same behavior.

[ecentinela]

Same problem here and this modification is working 👍

[ecentinela]

Please, merge this ASAP.

[stephpy]

ping @sanpii.

Please. :)

[gmorel]

👍

[stephpy]

@sanpii May be you need some help to maintain this library ?

[stephpy]

I guess https://github.com/sanpii/behatch-contexts/pull/87/files is more complete than this one. Could we close this one and merge the #87 ?

[stephpy]

And it has to be done on master and dev-behat2.x

[sanpii]

Merged, sorry for the delay.

@sanpii May be you need some help to maintain this library ?

Help is welcome, you can follow (and contribute) to #91