Skip to content

Align Cache with FileCache implementation #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Align Cache with FileCache implementation #655

wants to merge 1 commit into from

Conversation

@xXLAOKOONXx
Copy link
Contributor

Related to issue #654 .

  • Aligned understanding of expiry duration (Now expires at creation + timespan even if the data was revisited)
  • Used CacheData instead of private classes
  • Renamed and extracted functionalities based on implementation in FileCache (Save and Load)

BenFradet
BenFradet approved these changes Feb 26, 2020
View reviewed changes
Copy link
Owner

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@BenFradet BenFradet requested a review from JanOuborny February 26, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenFradet BenFradet BenFradet approved these changes

@JanOuborny JanOuborny Awaiting requested review from JanOuborny

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xXLAOKOONXx @BenFradet