Skip to content

Fix: Ensure TransformComponent Handles Conditional Rendering Gracefully #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

Fix: Ensure TransformComponent Handles Conditional Rendering Gracefully #520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/core/bounds/bounds.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,12 @@ export const calculateBounds = (
const { centerZoomedOut } = contextInstance.setup;

if (!wrapperComponent || !contentComponent) {
throw new Error("Components are not mounted");
return {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this causes resetTransform to not work

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How exactly? I mean this change should affect anything only at first render time to prevent this component throwing an error in case of a delayed render of a children.

minPositionX: 0,
maxPositionX: 0,
minPositionY: 0,
maxPositionY: 0,
}
}

const {
Expand Down