This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Prevents emitTabChange if entire FormWizard component is removed#349
Open
paulogiacomelli wants to merge 1 commit intoBinarCode:masterfrom
Open
Prevents emitTabChange if entire FormWizard component is removed#349paulogiacomelli wants to merge 1 commit intoBinarCode:masterfrom
paulogiacomelli wants to merge 1 commit intoBinarCode:masterfrom
Conversation
…ng the entire form
Contributor
|
I think it is correct the way it is, can you expand on your use case? Why does it bother you that removeTab is called when destroying the wizard? Thanks for your time. |
Author
|
Hey @BRafols, Currently, we have actions that run on Let say the user is on a tab and on Hope this helps clarify the use case. Thank you for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, once we navigate away from the the view with
vue-form-wizardcomponent,removeTabfunction is called, which emits multiple tabChange events fromemitTabChange.This PR's goal is to avoid calling
removeTaband consequentlyemitTabChangeif we are destroying the entire FormWizard component.