Skip to content

Conversation

jacobd91
Copy link
Contributor

@jacobd91 jacobd91 commented Oct 17, 2025

This PR simply adds a link to the error message if the DNS status check comes back as not pointing to the CDN

The link won't work as the article is still a draft, but the slugs have been synced so once it's published the link should work correctly. Here is the link to the draft article https://www.boldgrid.com/support/?p=164753&preview=true

@jacobd91 jacobd91 self-assigned this Oct 17, 2025
@jacobd91 jacobd91 marked this pull request as draft October 17, 2025 17:32
@jacobd91 jacobd91 changed the base branch from master to total-cdn-staging October 17, 2025 17:32
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 2.28%. Comparing base (754eb42) to head (7db0219).

Files with missing lines Patch % Lines
Cdnfsd_TotalCdn_Page.php 0.00% 18 Missing ⚠️
Cdnfsd_TotalCdn_Status_Dns.php 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             total-cdn-staging    #1225      +/-   ##
=======================================================
- Coverage                 2.28%    2.28%   -0.01%     
  Complexity               20202    20202              
=======================================================
  Files                      669      669              
  Lines                   102021   102039      +18     
=======================================================
  Hits                      2335     2335              
- Misses                   99686    99704      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacobd91 jacobd91 marked this pull request as ready for review October 20, 2025 18:47
@cssjoe cssjoe added this to the 2.9.0 (tcdn) milestone Oct 20, 2025
Copy link
Member

@cssjoe cssjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

Also, the article says to update "www" in step 2 and the "apex" in step 3. We want to make it clear that they would do one or the other, depending on their siteurl hostname.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants