-
-
Notifications
You must be signed in to change notification settings - Fork 305
chore: Add SVG export functionality and enhance samples page with categorized regex examples #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
persist-1
wants to merge
14
commits into
Bowen7:main
Choose a base branch
from
persist-1:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new DOM:Export the preview image as svg(With corresponding translation)
- New category added - Organize the samples according to their classification - Add more samples
- all 'console.log' has been removed to make the code clearer and more concise - removed the redundant comments - Convert all Chineset comments to English and make the English comments the default comments - Whether it is comments or front-end text, English is set as the default - Optimized the decoding of special symbols in the export as svg function - The style effect and layout design of the samples page have been optimized
@persist-1 is attempting to deploy a commit to the Bowen's projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat:
chore:
my words
This pr is a further improvement based on #155, optimizing the code logic, reducing unnecessary code, and further optimizing the new functions involved.
I deployed the static resources I built through the page feature provided by cloudflare and obtained an online preview website, which can be intuitively compared with the functional improvements of the current official website.
my dev website: https://regex-vis-persist1.pages.dev/
official website: https://regex-vis.com/
The image display of the international translation of the samples page as follows:




The image display of the function of exporting as svg is as follows:

svg:


From your suggestions, I really learned a lot of experience and lessons. As an amateur student developer, I haven't been involved in many open-source projects or large-scale projects before, and I don't have a sufficient understanding of implementing best practices as well as some development rules and wisdom.
If possible, could you please review my pr again? I'm really sorry to have taken up your time.
And It would be my honor if I could truly contribute a bit to this project.