Improve Navigator (Feature Complete for First Release) #49

Zoriot · 2025-09-08T20:04:55Z

Closes #37.

Zoriot · 2025-09-08T20:06:23Z

Missing things:

Test everything
Update documentation
(Optional) Better Player Connection Failure (Server Switch, Warp, Tpll) handling
(Optional) Warp Tags
Fix that the Warp right click menu is displayed for Oceania even they have no warps -> Other Warp Group should only be added if there are other warps.

You can try a up to date Version there: BuildTeamTools-0.1.3.6-alpha-Zori.jar

kyanvde

All in all looks good, couple small things that aren't really necessary but could be nice. There is one TO-DO you left behind though that might be important.

kyanvde · 2025-09-11T18:06:05Z

README.md

 1. Download BuildTeamTools [here](https://www.spigotmc.org/resources/buildteamtools.101854/).
 2. Place the downloaded plugin in your server's **../plugins** folder.
-3. *(Optional)* Some of the modules require intial configuration or dependencies to run:
+3. *(Optional)* Some of the modules require initial configuration or dependencies to run:


I think (if this works correctly) that the dependencies get automatically installed if needed so maybe this should be mentioned too.

I don't see any code which does it. Can you please give me a link?

src/main/java/net/buildtheearth/modules/ModuleHandler.java

src/main/java/net/buildtheearth/modules/navigation/components/warps/WarpsComponent.java

src/main/java/net/buildtheearth/modules/navigation/components/warps/menu/WarpGroupEditMenu.java

src/main/java/net/buildtheearth/modules/navigation/components/warps/menu/WarpGroupMenu.java

src/main/resources/modules/navigation/config.yml

kyanvde · 2025-09-11T19:08:37Z

Does this PR also close #35 ? Else that might be a nice thing to fix.

Zoriot · 2025-09-12T09:24:15Z

Does this PR also close #35 ? Else that might be a nice thing to fix.

Not yet, also i think it's also fine to do it outside of it.

kyanvde

LGTM, note that I have not tested anything ingame.

Copilot

Pull Request Overview

This PR implements feature completeness for the Navigator, expanding its functionality with new configuration options, improved menu handling, better server switching capabilities, and enhanced user experience features. It adds support for multiple build team server types and introduces new navigation utilities.

Key changes include:

Configuration updates with new navigation items (plotsystem, explore) and warp sorting options
Enhanced server switching with transfer capabilities and improved error handling
New BuildTeam command for direct team navigation with tab completion

Reviewed Changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/main/resources/plugin.yml	Updates command structure and adds new buildteam command with aliases
src/main/resources/modules/navigation/config.yml	Adds new navigation items and warp sorting configuration
src/main/java/net/buildtheearth/utils/io/ConfigPaths.java	Defines config paths for new navigation features
src/main/java/net/buildtheearth/utils/Utils.java	Removes unused methods and fixes boolean operators
src/main/java/net/buildtheearth/utils/ChatHelper.java	Adds error logging method with exception parameter
src/main/java/net/buildtheearth/modules/network/	Network model updates, API improvements, and transfer support
src/main/java/net/buildtheearth/modules/navigation/	Major navigation enhancements including new utilities, menu improvements, and warp functionality
src/main/java/net/buildtheearth/modules/generator/	Minor command structure improvements
src/main/java/net/buildtheearth/modules/common/	Command registration updates and module handling improvements
pom.xml	Dependency version updates for XSeries and AnvilGUI
README.md	Documentation updates with new wiki links and contributor additions

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/main/java/net/buildtheearth/modules/navigation/components/tpll/TpllComponent.java

src/main/java/net/buildtheearth/modules/network/api/NetworkAPI.java

MineFact · 2025-09-27T10:11:33Z

src/main/java/net/buildtheearth/modules/navigation/NavUtils.java

+        player.sendMessage("");
+        player.spigot().sendMessage(comp);
+        player.sendMessage("");
+        player.sendMessage("§cClick the IP to copy → Press ESC → Back to Menu → Multiplayer → Add Server → Ctrl+V → Done → Join.");


If command is suggested, players will have to copy the IP first with ctrl+A and Ctrl+C
What about Mac users?

MineFact · 2025-09-27T10:18:17Z

src/main/java/net/buildtheearth/modules/navigation/components/tpll/TpllComponent.java

        super("Tpll");
    }

+    public static final NamespacedKey TPLL_COOKIE_KEY = NamespacedKey.minecraft("btt_buildteam_tpll");


Is the cookie deleted automatically afterwards?

MineFact · 2025-09-27T10:40:11Z

src/main/java/net/buildtheearth/modules/navigation/menu/CountrySelectorMenu.java

        for (Region region : countries) {
            ArrayList<String> countryLore = ListUtil.createList("", "§eBuild Team:", region.getBuildTeam().getBlankName(), "", "§eArea:", formatArea(region.getArea()) + " km²", "", "§8Click to join this country's server!");
+            if (!region.getBuildTeam().getWarpGroups().isEmpty()) {
+                countryLore.add("Right click to open the warp menu!");


change to warp group menu

MineFact · 2025-09-27T10:51:00Z

src/main/resources/modules/navigation/config.yml

  # The hotbar slot into which the navigator item should be placed
  nav-slot: 0

+# ACTION - Blow you can define actions for some items. There is a comment when a default action exists, else it will error out.


MineFact · 2025-09-27T11:00:10Z

remove chat prefix from lore

MineFact · 2025-09-27T11:03:51Z

Tab completer contains color coded build team names, which can't be selected by typing the first characters of it.

MineFact · 2025-09-27T11:34:23Z

Explore Item
change the explore item click event:

if the player leftclicks on the item, it should open the build team warp group menu
if the player rightclicks on the item, it should open the continent selection menu
add this to the lore of the item

Plot System Item
Add a plotsystem item to the navigator menu

Build Item
Disable it by default and enable plot system item by default instead.

… inside

The canvas lib update was required to fix a menu bug, where sometimes the listener wasn't working. In the plugin.yml PlotSystem-Terra was added as a soft-depend, so our detection can reliabel work. Added myself as an author. Updated the Readme to reflect the current state.

It's only a short-term solution. Long term we should use smt local because of speed & rate limits. Nominatim just blocked my server :c.

…andling - Improved the CountrySelectorMenu for better usability and performance - Enhanced click handlers for countries: - Connected build teams allow direct player transfer to server - Optimized IP and port extraction using indexOf and substring - Added appropriate messages for missing connections or IPs - Improved area number formatting with dot notation for thousands separators - Added debug logging to track clicks and menu actions - Adjusted menu masking for consistent layout These changes improve navigation flow, visual clarity, and system stability while providing a better player experience when exploring different regions.

Otherwise it will not work & paper will throw a exception that i only can be opened on main thread.

So you can test api related things more easily.

…d interception

…ce BuildTeam model

…ion - fixes slots in warp group

…ate parsing

…and enhance permissions handling

…andling logic

…ata handling

…st and adding nullability annotations

…e warp menu access

MineFact · 2025-10-30T16:51:51Z

When you click "Back" in the Warp Group Menu it doesnt work

Navigator > Explore R > Continent > Country R > Back

kyanvde previously approved these changes Sep 11, 2025

View reviewed changes

Zoriot dismissed kyanvde’s stale review via 1b81bf4 September 17, 2025 13:08

Zoriot requested a review from kyanvde September 17, 2025 13:09

kyanvde reviewed Sep 20, 2025

View reviewed changes

Zoriot self-assigned this Sep 24, 2025

Zoriot added the enhancement New feature or request label Sep 24, 2025

Zoriot added this to the Release v1.0.0 milestone Sep 24, 2025

Zoriot requested a review from Copilot September 24, 2025 21:31

Copilot AI reviewed Sep 24, 2025

View reviewed changes

MineFact previously approved these changes Sep 27, 2025

View reviewed changes

Zoriot dismissed MineFact’s stale review via 0667153 October 18, 2025 22:05

Zoriot added 13 commits October 19, 2025 00:06

feat(common): ♻️ allow btt commands via console and simplify bt infos…

c5274c1

… inside

fix(network): 🐛 change from nominatim to photon api for osm data

dbd26fc

It's only a short-term solution. Long term we should use smt local because of speed & rate limits. Nominatim just blocked my server :c.

feat(nav/warps): 🐛 open warpeditmenu on main thread

96ed902

Otherwise it will not work & paper will throw a exception that i only can be opened on main thread.

[WIP] feat(navigator/tpll): ✨ use cookie for server-transfer-tpll's

9a8d5a6

[WIP] feat(network/api): ✨ add local buildteam api

f67777b

So you can test api related things more easily.

fix(navigator/tpll): 🩹 handle empty tpll the right way

a3c712b

feat(navigator): ✨ streamline team switching logic and improve comman…

3f70108

…d interception

feat(navigator): ✨ add buildteam command for team switching and enhan…

2dd1dfa

…ce BuildTeam model

fix(navigator): ✨ add sorting mode and implement auto slot recalculat…

7744efd

…ion - fixes slots in warp group

feat(navigator): ✨ enhance command tab completion and improve coordin…

c7d625b

…ate parsing

feat(navigator): ✨ add warp menu access for regions with warp groups …

aed4c12

…and enhance permissions handling

Zoriot added 6 commits October 19, 2025 00:08

feat(navigator): ✨ enhance navigator configuration and improve warp h…

73d6363

…andling logic

chore(nav): refactor slots and correct logic for it

e2e4506

chore(nav): fix the osm lookup

f68eb22

fix(navigator): correct area conversion and improve player transfer d…

3e4efcf

…ata handling

refactor(item): ♻️ improve type safety by replacing ArrayList with Li…

acf0b2a

…st and adding nullability annotations

feat(navigator): ✨ implement warps command for build teams and enhanc…

dfe4e24

…e warp menu access

Zoriot force-pushed the improveNavigator branch from 0667153 to dfe4e24 Compare October 18, 2025 22:10

MineFact approved these changes Oct 30, 2025

View reviewed changes

Improve Navigator (Feature Complete for First Release) #49

Are you sure you want to change the base?

Improve Navigator (Feature Complete for First Release) #49

Uh oh!

Conversation

Zoriot commented Sep 8, 2025

Uh oh!

Zoriot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kyanvde left a comment

Choose a reason for hiding this comment

Uh oh!

kyanvde Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Zoriot Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Zoriot Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyanvde commented Sep 11, 2025

Uh oh!

Zoriot commented Sep 12, 2025

Uh oh!

kyanvde left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MineFact Sep 27, 2025

Choose a reason for hiding this comment

Uh oh!

MineFact Sep 27, 2025

Choose a reason for hiding this comment

Uh oh!

MineFact Sep 27, 2025

Choose a reason for hiding this comment

Uh oh!

MineFact Sep 27, 2025

Choose a reason for hiding this comment

Uh oh!

MineFact commented Sep 27, 2025

Uh oh!

MineFact commented Sep 27, 2025

Uh oh!

MineFact commented Sep 27, 2025

Uh oh!

MineFact commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Zoriot commented Sep 8, 2025 •

edited

Loading

MineFact commented Oct 30, 2025 •

edited

Loading