tweakable apartment max size

[standmit]

Summary by CodeRabbit

• Refactor
  • Made the apartment size limit now configurable through settings instead of hard-coded, allowing users greater flexibility in setting custom apartment sizing constraints.

[coderabbitai]

Walkthrough

The change replaces hard-coded area limit checks (value 10) with a configurable max_side variable initialized from the apartment.max_side setting in two validation locations within the GUI module.

Changes

Cohort / File(s)	Summary
Configuration variable refactor gui.lua	Added max_side variable from apartment settings; replaced two hard-coded limit values (10) with this configurable variable in GUI validation logic

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

• Localized change affecting a single file
• Simple pattern: variable initialization and two value replacements
• No new logic, control flow, or exported API changes
• Straightforward variable sourcing from settings

Poem

🐰 A number once carved in stone so deep,
Now dances free where configs sleep,
Ten becomes a tale to tell,
Where max_side rings its flexing bell! 🔔

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "tweakable apartment max size" accurately reflects the main change in the changeset. The modifications introduce a configurable max_side variable initialized from an apartment.max_side setting, replacing hard-coded limit checks throughout the code. The title is concise, specific, and clearly communicates the primary objective—making the apartment maximum size configurable rather than hard-coded. A teammate reviewing the git history would immediately understand the purpose of this change from the title alone.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

gui.lua (1)

123-126: Improve error message to include the maximum allowed value.

The validation logic correctly uses max_side, but the error message on line 124 could be more helpful by informing users of the actual maximum allowed value.

Apply this diff to improve the error message:

 						if math.max(size_left, size_right, size_up, size_down, size_front, size_back) > max_side then
-							minetest.chat_send_player(name, S("Error: The area is too large."))
+							minetest.chat_send_player(name, S("Error: The area is too large. Maximum side length is @1.", max_side))
 							return
 						end

Note: Ensure the translation string supports the @1 placeholder for the max_side value.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba28ea3 and 29ef160.

📒 Files selected for processing (1)

• gui.lua (2 hunks)

🔇 Additional comments (2)

gui.lua (2)

4-4: LGTM! Configuration setting properly implemented.

The use of tonumber() with a fallback to 10 is appropriate. Note that this module-level variable is initialized once at server start, so changes to the apartment.max_side setting will require a server restart to take effect.

---

123-123: No action needed—verification confirms code is correct.

The search found only one validation location at line 123, which correctly uses the configurable max_side variable (defined at line 4 with a default fallback to 10). No other hardcoded size limit references exist in the codebase that require updating. The AI summary's mention of "two validation locations" appears to be inaccurate; there is only one size validation check.