support smartshop:storage

[standmit]

Summary by CodeRabbit

• New Features

  • Smartshop storage objects now support ownership and initialization handling, matching standard shop behavior.

• Chores

  • Added smartshop to optional dependencies.

[coderabbitai]

Walkthrough

The changes add support for smartshop storage objects in the apartment change-owner functionality by introducing a new conditional branch that handles initialization of smartshop storage nodes. Additionally, the mod configuration extends optional dependencies to include smartshop.

Changes

Cohort / File(s)	Change Summary
Smartshop storage initialization chg_owner.lua	Adds a special-case branch for smartshop:storage nodes. When the node is smartshop storage and smartshop.api.get_object is available, retrieves the object, initializes metadata with effective owner, initializes inventory, and updates appearance—mirroring existing smartshop shop handling.
Dependency configuration mod.conf	Extends optional_depends to include smartshop alongside the existing default dependency.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• chg_owner.lua: Review the new conditional branch logic for smartshop storage—verify it correctly parallels the existing smartshop shop handling and integrates properly with the change-owner flow.
• mod.conf: Verify the optional dependency addition doesn't introduce unexpected load order or compatibility issues.

Poem

🐰 A storage for shops, how splendid and bright,
Smart shelves now remember their owner's delight,
Through metadata blessed and inventories lined,
The rabbit hops on—more features aligned!
✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "support smartshop:storage" is concise, clear, and directly reflects the main changes in this pull request. The primary change is the addition of logic to handle smartshop storage objects in chg_owner.lua, with a supporting dependency update in mod.conf to include smartshop. The title accurately captures this primary objective without being vague, misleading, or overly broad. A teammate reviewing the commit history would immediately understand that this PR adds support for a new smartshop node type.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba28ea3 and 793224f.

📒 Files selected for processing (2)

• chg_owner.lua (1 hunks)
• mod.conf (1 hunks)

🔇 Additional comments (2)

mod.conf (1)

5-5: LGTM!

The addition of smartshop to optional dependencies is correct and necessary to support the smartshop:storage handling added in chg_owner.lua.

chg_owner.lua (1)

55-59: The review comment is based on incorrect assumptions about smartshop API design and should be disregarded.

Flux's smartshop provides two distinct node types: a shop and an external storage, while AiTechEye's smartshop only has "wifi storage" (external storage for shops)—not separate storage nodes.

The two concerns raised are incorrect:

1. Missing set_unlimited(false) is intentional. Unlimited inventory is only an option for shop nodes, not storage objects. Storage objects are pure inventory containers without unlimited mode. Calling set_unlimited() on a storage object would be semantically incorrect.

2. No AiTechEye variant is correct. AiTechEye's smartshop doesn't provide a smartshop:storage node type at all—it only has shops. There is nothing to handle for a node type that doesn't exist in that variant.

The storage and shop handling code are intentionally different because they represent different object types with different capabilities. The storage code correctly omits set_unlimited() because storage objects do not support that feature.

Likely an incorrect or invalid review comment.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}