Heaving-WMT decomposition V1 #620
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
edoddridge
reviewed
Sep 9, 2025
|
I just added a new commit! |
edoddridge
reviewed
Sep 16, 2025
| @@ -0,0 +1,1863 @@ | |||
| { | |||
There was a problem hiding this comment.
The new function name is much clearer, thanks!
I should have mentioned this in the first review, but it is generally better to include required variables in the function call, rather than relying on them as global variables. In this case, the function needs start_time, end_time, lat_slice, and lon, but none of them are included in the function call.
Reply via ReviewNB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This notebook is to decompose variable changes (e.g., temperature, salinity, age tracer) into changes along isopyncals (water mass transformation) and isopycnal heaving. I used
xgcmto do depth-density coordinate transfers and calculate the changes along isopycnals. After that, I transfer this change back to the depth coordinate. The residual term (total change minus change along the isopycnal) is referred to as the change due to isopycnal heaving.