Revert agnosticity and make Surface Water Mass Transformation Recipe MOM6 specific #623
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
navidcy
changed the title
|
is this ready to be reviewed @willaguiar? |
|
Yes! |
| @@ -8,7 +8,7 @@ | |||
| "\n", | |||
There was a problem hiding this comment.
LOVE THE TABLE
Given that we remove the client info (I like), should we also include here session requirements? I.e. choose a large one?
Reply via ReviewNB
| @@ -8,7 +8,7 @@ | |||
| "\n", | |||
There was a problem hiding this comment.
Line #20. warnings.filterwarnings("ignore", category = FutureWarning)
Apparently this is bad practice and we should not use :(
Reply via ReviewNB
| @@ -8,7 +8,7 @@ | |||
| "\n", | |||
There was a problem hiding this comment.
Maybe the functions are not the clearer way to do this? but I think it might be too much for this pull request, it can be done after this is merged!
Reply via ReviewNB
| @@ -8,7 +8,7 @@ | |||
| "\n", | |||
There was a problem hiding this comment.
Do these values represent upwelling/downwelling? My understanding was that positive means waters becoming denser, negative waters become lighter. If they are dense enough or not to subduct depends on surrounding stratification. And then because this is at the surface becoming lighter does not trigger upwelling. But maybe I'm wrong?
Reply via ReviewNB
There was a problem hiding this comment.
Having done a bit of reading the magnitude that is related to upwelling/downwelling is the derivative of the transformation rate with respect to density (
I'm not sure if this is correct then, but would the amount upwelled would then be 30Sv? Need @adele-morrison @AndyHoggANU to help me jaja
| @@ -8,7 +8,7 @@ | |||
| "\n", | |||
There was a problem hiding this comment.
Maybe comment in line about this being an integration? Multiplying by area and summing?
Reply via ReviewNB
| @@ -8,7 +8,7 @@ | |||
| "\n", | |||
There was a problem hiding this comment.
| @@ -8,7 +8,7 @@ | |||
| "\n", | |||
There was a problem hiding this comment.
3 participants
Fixes issue #590
Notebook converted back from model-agnostic to MOM6-based. Specific additional directions are given on how to alter the notebook to work with MOM5 (ACCESS-OM2-01). An additional if statement was added, to convert the temperature for potential to conservative, only when the input variable is potential temperature. This line comes with a warning, and was added so the code can work correctly by just changing the diagnostic variables for MOM5 ( i.e., the conditional only perform the conversion when the output is named according to the MOM6 standard naming for potential density)