-
Notifications
You must be signed in to change notification settings - Fork 75
Reduces compute time & fixes maps #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@polinaesia, the first comment in the PR is very descriptive -- nice! |
|
@navidcy I can't change the title, soz, will make it more informative next time |
|
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2025-10-13T01:18:05Z Line #9. import logging Apparently we shouldn't suppress warnings :( |
|
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2025-10-13T01:18:06Z Why does this look different if they're the same experiment and same time period? polinaesia commented on 2025-10-13T02:05:31Z You mean the values? If so, it's because I adjusted the contour levels instead of leaving them automatic as in the original. However, if you mean the shape of the continents in the NH, the original recipe was incorrect and distorted the Arctic. julia-neme commented on 2025-10-13T03:10:08Z Ups sorry I didn't realise there were extra levels sorry! |
|
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2025-10-13T01:18:07Z Also a lot lot slower than the OG. |
|
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2025-10-13T01:18:07Z Also looks different?
polinaesia commented on 2025-10-13T02:05:57Z Same answer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments in reviewNB
|
You mean the values? If so, it's because I adjusted the contour levels instead of leaving them automatic as in the original. However, if you mean the shape of the continents in the NH, the original recipe was incorrect and distorted the Arctic. View entire conversation on ReviewNB |
|
Same answer View entire conversation on ReviewNB |
|
Ups sorry I didn't realise there were extra levels sorry! View entire conversation on ReviewNB |

This PR keeps plots stable by replacing Intake-attached
geolon_t/geolat_tonhtwith the unmaskedgeolon_t/geolat_tcoordinates from ocean_grid.nc (raised in #556). This is necessary because the coordinates currently attached by Intake are masked over continents (contain NaNs), and Cartopy fails to produce figure when x/y include NaNs (e.g. GEOSException: Points of LinearRing do not form a closed linestring)What's improved:
What needs fixing:
Ensure Intake loader attaches unmasked geolon_t/geolat_t
p.s. I also added Claire's note on MOM5-to-MOM6 conversion raised in
#581.