Skip to content

Fix errors when loading with jQuery 3 #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix errors when loading with jQuery 3 #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc9eae2
Replace deprecated use of load()
fulv May 3, 2019
c216d14
Update jquery.anythingslider.min.js
fulv May 3, 2019
0dec2b6
Update all the demos.
fulv May 4, 2019
141a867
Merge pull request #1 from fulv/jq3
fulv May 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions css3.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<link rel="apple-touch-icon" href="demos/images/apple-touch-icon.png">

<!-- jQuery (required) -->
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8/jquery.min.js"></script>
<script src="https://code.jquery.com/jquery-3.4.1.min.js"></script>
<script>window.jQuery || document.write('<script src="js/jquery.min.js"><\/script>')</script>

<!-- Demo stuff -->
Expand Down Expand Up @@ -127,4 +127,4 @@ <h3 class="ani">Change first slide animations:</h3>

</body>

</html>
</html>
4 changes: 2 additions & 2 deletions demos.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

<!-- jQuery (required) & jQuery UI (for this demo only) -->
<link rel="stylesheet" href="https://code.jquery.com/ui/1.10.0/themes/base/jquery-ui.css">
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8/jquery.min.js"></script>
<script src="https://code.jquery.com/jquery-3.4.1.min.js"></script>
<script>window.jQuery || document.write('<script src="js/jquery.min.js"><\/script>')</script>
<script src="https://code.jquery.com/ui/1.10.0/jquery-ui.js"></script>

Expand Down Expand Up @@ -743,4 +743,4 @@ <h3><a href="#">Script - FX addon, using custom FX</a></h3>

</body>

</html>
</html>
2 changes: 1 addition & 1 deletion demos/js/jquery.jatt.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion expand.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<link rel="apple-touch-icon" href="demos/images/apple-touch-icon.png">

<!-- jQuery (required) -->
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8/jquery.min.js"></script>
<script src="https://code.jquery.com/jquery-3.4.1.min.js"></script>
<script>window.jQuery || document.write('<script src="js/jquery.min.js"><\/script>')</script>

<!-- Demo stuff -->
Expand Down
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<link rel="apple-touch-icon" href="demos/images/apple-touch-icon.png">

<!-- jQuery (required) -->
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.8/jquery.min.js"></script>
<script src="https://code.jquery.com/jquery-3.4.1.min.js"></script>
<script>window.jQuery || document.write('<script src="js/jquery.min.js"><\/script>')</script>

<!-- Syntax highlighting -->
Expand Down
6 changes: 3 additions & 3 deletions js/jquery.anythingslider.fx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
if (slider.options.animationTime < defaults.timeOut) {
time = slider.options.animationTime || defaults.timeOut;
}
page = page.find('*').andSelf(); // include the panel in the selectors
page = page.find('*').addBack(); // include the panel in the selectors
for (el in FX) {
if (el === 'outFx') {
// process "out" custom effects
Expand Down Expand Up @@ -153,7 +153,7 @@
if (defaults.stopRepeat && slider.$lastPage[0] === slider.$targetPage[0]) { return; }
var el, elIn, page = slider.$currentPage.add( slider.$items.eq(slider.exactPage) ),
FX = slider.fx; // allow dynamically added FX
page = page.find('*').andSelf(); // include the panel in the selectors
page = page.find('*').addBack(); // include the panel in the selectors
for (el in FX) {
if (el === 'inFx') {
// process "in" custom effects
Expand Down Expand Up @@ -181,7 +181,7 @@
.data('AnythingSlider');

// call gotoPage to trigger intro animation
$(window).load(function(){ base.gotoPage(base.currentPage, base.playing); });
$(window).on('load', function(){ base.gotoPage(base.currentPage, base.playing); });

});
};
Expand Down
Loading