CTH LOGIN #73
Open
CTH LOGIN #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eaned up the default code in the layout, page, and globals.css. Inside layout, added app wide metadata via the new nextjs 13 features that include an exported metadata function for better seo, for when webcrawlers crawl the internet. Its app wide since the route layout wraps all pages, and will be the default metadata unless we give a page metadata, for which it would be page specific metadata
…rate best practices, I made the form a custom form that provides scalability, so if we eventually have multiple inputs, we can use this custom form to map over inputs. This ensures that if we eventualy have a form with multiple inputs, the form always stays the same but is passed the values from the page in a more readable way. Added an extra security feature of canSave, where if the email and password are not booleans, you cant use the button. Added basic tailwind styling for basic viewing. State of email and password is managed via useState, with the values being updated via their respective handler functions.
…nvalid state, if email doesnt contain @, both the error message will be set, and the boolean value of formIsInvalid will be set. And vice versa, to clear the styling and error message, if it does contain an @, the error message is cleared, and the error styling is taken away. Just as the last commits suggest, its always good to demonstrate the scalability, hence in the CustomFOrm component, we also have more control on how to style the label based on that labels error, if you did want to style different errors differently
|
Great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enjoy