Shaun Aranha dev-test-exercise #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting a pull request for the dev-test-exercise including a Login Field that contains the email and password fields.
As per the stakeholder's request, no functionality was added except for the email field border changing to red and a notification under the fields indicating that a user has typed in an invalid email.
I used components from shadcn/ui (https://ui.shadcn.com/) and styled it with tailwind accordingly.
Since the login page would require possible additional components or logic, I chose to give it its own separate folder under app/login. In the folder, I have a form.tsx file and a page.tsx file in the folder simplify each file's purpose and use as much as possible.