switched recursive network tweets processing to loop method. #94
Conversation
| depthDict = {} | ||
| depthDict[0] = [[id2, username]] |
There was a problem hiding this comment.
why does this need a dictionary of lists of tuples for all of the different rounds instead of just a single list of tuples of user ids/usernames for the next round?
| depthDict[0] = [[id2, username]] | ||
|
|
||
| for i in range(0, depth+1): | ||
| for l in range(0, len(depthDict[i])): |
There was a problem hiding this comment.
would you please rename this index variable to anything other than the letter 'l' (el)? Even with text highlighting from Github/IDE's, it's still confusing to read (i.e. looks like the number 1).
|
|
||
|
|
||
|
|
||
| def get_network_tweets_text(self, id2, username, count, depth): |
There was a problem hiding this comment.
this unfortunately conflicts with changes made in the most recent branch merged into master (making the friends-vs-followers toggle on the word cloud page work). Would you please modify this code to mimic those changes to this function?
| textsStr = "" | ||
| if id2 > 0 or username is not None: | ||
| # get bunch of tweets starting with the user of given id | ||
| n = depth # goes depth level deep |
There was a problem hiding this comment.
what is the value of this alias? it seems to me that it makes the code below less clear.
| friendsid = self.twitter.getFriendsID(depthDict[i][l][0], depthDict[i][l][1], count) | ||
| for id3 in friendsid: |
There was a problem hiding this comment.
this unfortunately conflicts with changes made in the most recent branch merged into master (making the friends-vs-followers toggle on the word cloud page work). Would you please modify this code to mimic those changes to this function?
switched recursive network tweets processing to loop method.