Skip to content

Conversation

@defining-art
Copy link

No description provided.

@bryanreiter
Copy link

I don't know if that switch case will ever run. It's in a useEffect that only runs once. That useEffect sets up the event stream for data to be sent to the browser. So since that useEffect runs once and then never again (since it sets up the stream), would that switch case ever be used? Maybe I'm misunderstanding the logic.

bryanreiter
bryanreiter previously approved these changes Apr 23, 2024
Copy link

@bryanreiter bryanreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

KevinXJarema
KevinXJarema previously approved these changes Apr 25, 2024
Copy link

@KevinXJarema KevinXJarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this.

…devices-and-viewing-currently-connected-devices
@defining-art defining-art dismissed stale reviews from KevinXJarema and bryanreiter via 696871e April 29, 2024 01:14
Copy link
Author

@defining-art defining-art left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge Conflict Solved

…devices-and-viewing-currently-connected-devices
…devices-and-viewing-currently-connected-devices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants