feat(query): implements "Beta - Storage Account With Shared Access Key"

assets/queries/terraform/azure/storage_account_with_shared_access_key/metadata.json

@@ -0,0 +1,14 @@
+{
+  "id": "45f3e879-f8a7-4102-a3fa-46da5a849870",
+  "queryName": "Beta - Storage Account With Shared Access Key",
+  "severity": "MEDIUM",
+  "category": "Access Control",
+  "descriptionText": "All 'azurerm_storage_account' resources should disable access key via 'Shared Key' for improved access control",
+  "descriptionUrl": "https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/storage_account#shared_access_key_enabled-1",
+  "platform": "Terraform",
+  "descriptionID": "45f3e879",
+  "cloudProvider": "azure",
+  "cwe": "1390",
+  "riskScore": "3.0",
+  "experimental": "true"
+}

assets/queries/terraform/azure/storage_account_with_shared_access_key/query.rego

@@ -0,0 +1,39 @@
+package Cx
+
+import data.generic.common as common_lib
+import data.generic.terraform as tf_lib
+
+CxPolicy[result] {
+	resource := input.document[i].resource.azurerm_storage_account[name]
+
+	results := get_results(resource, name)
+
+	result := {
+		"documentId": input.document[i].id,
+		"resourceType": "azurerm_storage_account",
+		"resourceName": tf_lib.get_resource_name(resource, name),
+		"searchKey": results.searchKey,
+		"issueType": results.issueType,
+		"keyExpectedValue": sprintf("'azurerm_storage_account[%s].shared_access_key_enabled' should be defined and set to false", [name]),
+		"keyActualValue": results.keyActualValue,
+		"searchLine": results.searchLine
+	}
+}
+
+get_results(resource, name) = results {
+	not common_lib.valid_key(resource, "shared_access_key_enabled")
+	results := {
+		"searchKey" : sprintf("azurerm_storage_account[%s]", [name]),
+		"issueType": "MissingAttribute",
+		"keyActualValue" : sprintf("'azurerm_storage_account[%s].shared_access_key_enabled' is undefined or null", [name]),
+		"searchLine" : common_lib.build_search_line(["resource", "azurerm_storage_account", name], [])
+	}
+} else = results {
+	resource.shared_access_key_enabled != false
+	results := {
+		"searchKey" : sprintf("azurerm_storage_account[%s].shared_access_key_enabled", [name]),
+		"issueType": "IncorrectValue",
+		"keyActualValue" : sprintf("'azurerm_storage_account[%s].shared_access_key_enabled' is set to '%s'", [name, resource.shared_access_key_enabled]),
+		"searchLine" : common_lib.build_search_line(["resource", "azurerm_storage_account", name, "shared_access_key_enabled"], [])
+	}
+}

assets/queries/terraform/azure/storage_account_with_shared_access_key/test/negative.tf

@@ -0,0 +1,10 @@
+resource "azurerm_storage_account" "negative1" {
+  name                     = "negative1"
+  resource_group_name      = "testRG"
+  location                 = "northeurope"
+  account_tier             = "Premium"
+  account_replication_type = "LRS"
+  account_kind             = "FileStorage"
+
+  shared_access_key_enabled = false    # value is set false
+}

assets/queries/terraform/azure/storage_account_with_shared_access_key/test/positive.tf

@@ -0,0 +1,19 @@
+resource "azurerm_storage_account" "positive1" {
+  name                     = "positive1"
+  resource_group_name      = azurerm_resource_group.positive1.name
+  location                 = azurerm_resource_group.positive1.location
+  account_tier             = "Standard"
+  account_replication_type = "GRS"
+
+  # missing "shared_access_key_enabled" (defaults to true)
+}
+
+resource "azurerm_storage_account" "positive2" {
+  name                     = "positive2"
+  resource_group_name      = azurerm_resource_group.positive2.name
+  location                 = azurerm_resource_group.positive2.location
+  account_tier             = "Standard"
+  account_replication_type = "GRS"
+
+  shared_access_key_enabled = true     # value is not set to false
+}

assets/queries/terraform/azure/storage_account_with_shared_access_key/test/positive_expected_result.json

@@ -0,0 +1,12 @@
+[
+  {
+    "queryName": "Beta - Storage Account With Shared Access Key",
+    "severity": "MEDIUM",
+    "line": 1
+  },
+  {
+    "queryName": "Beta - Storage Account With Shared Access Key",
+    "severity": "MEDIUM",
+    "line": 18
+  }
+]

assets/similarityID_transition/terraform_azure.yaml

@@ -3,6 +3,10 @@ similarityIDChangeList:
       queryName: Sensitive Port Is Exposed To Wide Private Network
       observations: ""
       change: 5
+    - queryId: 45f3e879-f8a7-4102-a3fa-46da5a849870
+      queryName: Beta - Storage Account With Shared Access Key
+      observations: ""
+      change: 2
     - queryId: 056d28cc-7ee9-4b12-b2d1-16b7b66db72d
       queryName: Beta - Blob Storage Without Soft Delete
       observations: ""