Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"id": "b373043c-f3bf-40db-b67a-c982732c7781",
"queryName": "Beta - Recovery Services Vault Without Soft Delete",
"severity": "HIGH",
"category": "Backup",
"descriptionText": "No 'azurerm_recovery_services_vault' resource should set 'soft_delete_enabled' to false, this makes it impossible to recover backup data",
"descriptionUrl": "https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/recovery_services_vault#soft_delete_enabled-1",
"platform": "Terraform",
"descriptionID": "b373043c",
"cloudProvider": "azure",
"cwe": "754",
"riskScore": "6.0",
"experimental": "true"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package Cx

import data.generic.common as common_lib
import data.generic.terraform as tf_lib

CxPolicy[result] {
resource := input.document[i].resource.azurerm_recovery_services_vault[name]

resource.soft_delete_enabled == false

result := {
"documentId": input.document[i].id,
"resourceType": "azurerm_recovery_services_vault",
"resourceName": tf_lib.get_resource_name(resource, name),
"searchKey": sprintf("azurerm_recovery_services_vault[%s].soft_delete_enabled", [name]),
"issueType": "IncorrectValue",
"keyExpectedValue": sprintf("'azurerm_recovery_services_vault[%s].soft_delete_enabled' should not be set to false", [name]),
"keyActualValue": sprintf("'azurerm_recovery_services_vault[%s].soft_delete_enabled' is set to false", [name]),
"searchLine": common_lib.build_search_line(["resource", "azurerm_recovery_services_vault", name, "soft_delete_enabled"], [])
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
resource "azurerm_recovery_services_vault" "negative1" {
name = "negative1-recovery-vault"
location = azurerm_resource_group.negative1.location
resource_group_name = azurerm_resource_group.negative1.name
sku = "Standard"

# "soft_delete_enabled" missing - defaults to true
}

resource "azurerm_recovery_services_vault" "negative2" {
name = "negative2-recovery-vault"
location = azurerm_resource_group.negative2.location
resource_group_name = azurerm_resource_group.negative2.name
sku = "Standard"

soft_delete_enabled = true
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
resource "azurerm_recovery_services_vault" "positive" {
name = "positive-recovery-vault"
location = azurerm_resource_group.positive.location
resource_group_name = azurerm_resource_group.positive.name
sku = "Standard"

soft_delete_enabled = false
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
[
{
"queryName": "Beta - Recovery Services Vault Without Soft Delete",
"severity": "HIGH",
"line": 7
}
]
4 changes: 4 additions & 0 deletions assets/similarityID_transition/terraform_azure.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ similarityIDChangeList:
queryName: Sensitive Port Is Exposed To Wide Private Network
observations: ""
change: 5
- queryId: b373043c-f3bf-40db-b67a-c982732c7781
queryName: Beta - Recovery Services Vault Without Soft Delete
observations: ""
change: 2
- queryId: 7a0164a5-ec6e-40b2-938d-ab3edfd37dcd
queryName: Beta - Backup Vault Without Immutability
observations: ""
Expand Down
Loading