Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"id": "d3ba7d62-bd07-4102-88ca-9668e5f08e7d",
"queryName": "Beta - Recovery Services Vault With Public Network Access",
"severity": "HIGH",
"category": "Access Control",
"descriptionText": "All 'azurerm_recovery_services_vault' resources should set 'public_network_access_enabled' to false in order to prevent exposure to the internet and reduce the risk of unauthorized access",
"descriptionUrl": "https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/recovery_services_vault#public_network_access_enabled-1",
"platform": "Terraform",
"descriptionID": "d3ba7d62",
"cloudProvider": "azure",
"cwe": "732",
"riskScore": "6.0",
"experimental": "true"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
package Cx

import data.generic.common as common_lib
import data.generic.terraform as tf_lib

CxPolicy[result] {
resource := input.document[i].resource.azurerm_recovery_services_vault[name]

results := get_results(resource, name)

result := {
"documentId": input.document[i].id,
"resourceType": "azurerm_recovery_services_vault",
"resourceName": tf_lib.get_resource_name(resource, name),
"searchKey": results.searchKey,
"issueType": results.issueType,
"keyExpectedValue": sprintf("'azurerm_recovery_services_vault[%s].public_network_access_enabled' should be defined and set to false", [name]),
"keyActualValue": results.keyActualValue,
"searchLine": results.searchLine
}
}

get_results(resource, name) = results {
not common_lib.valid_key(resource, "public_network_access_enabled")
results := {
"searchKey": sprintf("azurerm_recovery_services_vault[%s]", [name]),
"issueType": "MissingAttribute",
"keyActualValue": sprintf("'azurerm_recovery_services_vault[%s].public_network_access_enabled' is undefined or null", [name]),
"searchLine": common_lib.build_search_line(["resource", "azurerm_recovery_services_vault", name], [])
}

} else = results {
resource.public_network_access_enabled == true
results := {
"searchKey": sprintf("azurerm_recovery_services_vault[%s].public_network_access_enabled", [name]),
"issueType": "IncorrectValue",
"keyActualValue": sprintf("'azurerm_recovery_services_vault[%s].public_network_access_enabled' is set to true", [name]),
"searchLine": common_lib.build_search_line(["resource", "azurerm_recovery_services_vault", name, "public_network_access_enabled"], [])
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
resource "azurerm_recovery_services_vault" "negative1" {
name = "negative1-recovery-vault"
location = azurerm_resource_group.negative1.location
resource_group_name = azurerm_resource_group.negative1.name
sku = "Standard"

public_network_access_enabled = false
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
resource "azurerm_recovery_services_vault" "positive1" {
name = "positive1-recovery-vault"
location = azurerm_resource_group.positive1.location
resource_group_name = azurerm_resource_group.positive1.name
sku = "Standard"

# "public_network_access_enabled" missing - defaults to true
}

resource "azurerm_recovery_services_vault" "positive2" {
name = "positive2-recovery-vault"
location = azurerm_resource_group.positive2.location
resource_group_name = azurerm_resource_group.positive2.name
sku = "Standard"

public_network_access_enabled = true
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
[
{
"queryName": "Beta - Recovery Services Vault With Public Network Access",
"severity": "HIGH",
"line": 1
},
{
"queryName": "Beta - Recovery Services Vault With Public Network Access",
"severity": "HIGH",
"line": 16
}
]
4 changes: 4 additions & 0 deletions assets/similarityID_transition/terraform_azure.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,7 @@ similarityIDChangeList:
queryName: Sensitive Port Is Exposed To Wide Private Network
observations: ""
change: 5
- queryId: d3ba7d62-bd07-4102-88ca-9668e5f08e7d
queryName: Beta - Recovery Services Vault With Public Network Access
observations: ""
change: 2
Loading