Fix/avoid re-entrance #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need ASM >=9 for this PR. The other stuff just seems to have broken over time.
Mixin does not allow re-entrance in plugins so we should not evaluate the args until runtime.
|
Running into this issue, merge would be great! (Thanks for the awesome library) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my other PR since I can't build otherwise.
Mixin strictly disallows re-entrance during transformation so we should avoid evaluating args suppliers at transformation-time, instead storing the supplier and evaluating it at runtime.
Currently if an arg supplier causes a classload for a class that has a mixin it will crash.