Prepare support Folia #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Euphillya
added a commit
to Euphillya/Citizens4Folia
that referenced
this pull request
Mar 23, 2025
Work is still in progress!
fullwall
requested changes
Aug 12, 2025
src/main/java/net/citizensnpcs/api/persistence/PotionEffectPersister.java
Show resolved
Hide resolved
src/main/java/net/citizensnpcs/api/util/schedulers/SchedulerRunnable.java
Outdated
Show resolved
Hide resolved
src/main/java/net/citizensnpcs/api/util/schedulers/adapter/FoliaScheduler.java
Outdated
Show resolved
Hide resolved
|
The only thing I'm unsure of is whether it's better to abstract the paper dependency change further into a submodule. The reason is less about paper vs spigot and more about paper's API backwards compatibility, which overall is less than spigot. |
fullwall
reviewed
Aug 14, 2025
|
Thanks so much for your hard work! Appreciated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started working on Folia support for Citizens a few weeks ago.
It’s quite a substantial task, but I’ve made a good start and I’m making steady progress with the time I have available alongside my other projects.
I’m already submitting a preview of the changes that need to be made to the API.
I’ve maintained compatibility with Spigot, which was essential.
I’m leaving this PR as a draft, as I may still make changes if anything needs to be adjusted.