This repository was archived by the owner on Jun 7, 2022. It is now read-only.
Removing the manuell download links and replacing them with an automatic system #348
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| package eu.cloudnetservice.cloudnet.v2.setup.models; | ||
|
|
||
| import eu.cloudnetservice.cloudnet.v2.lib.NetworkUtils; | ||
|
|
||
| import java.io.BufferedReader; | ||
| import java.io.IOException; | ||
| import java.io.InputStream; | ||
| import java.io.InputStreamReader; | ||
| import java.net.URL; | ||
| import java.net.URLConnection; | ||
|
|
||
| public class GetBukkitVersion { | ||
| private final String version; | ||
| private final URL previewURL; | ||
|
|
||
| public GetBukkitVersion(String version, URL previewDownload) { | ||
| this.version = version; | ||
| this.previewURL = previewDownload; | ||
| } | ||
|
|
||
| private URL revealDownload() { | ||
| try { | ||
| URLConnection connection = previewURL.openConnection(); | ||
| connection.setRequestProperty("User-Agent", NetworkUtils.USER_AGENT); | ||
| connection.connect(); | ||
|
|
||
| InputStream input = connection.getInputStream(); | ||
| try (BufferedReader reader = new BufferedReader(new InputStreamReader(input))) { | ||
| String line; | ||
| while ((line = reader.readLine()) != null) { | ||
| if (!line.contains("href=\"https://cdn.getbukkit.org/spigot")) continue; | ||
|
|
||
| int linkStart = line.indexOf("\""); | ||
| linkStart++; | ||
| int linkEnds = line.indexOf("\"", linkStart); | ||
|
|
||
| String downloadLink = line.substring(linkStart, linkEnds); | ||
| return new URL(downloadLink); | ||
| } | ||
| } | ||
| } catch (IOException exception) { | ||
| exception.printStackTrace(); | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| public URL getDownloadURL() { | ||
| return revealDownload(); //Only load when needed to minimize delay | ||
| } | ||
|
|
||
| public String getVersion() { | ||
| return version; | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| package eu.cloudnetservice.cloudnet.v2.setup.spigot; | ||
|
|
||
| import eu.cloudnetservice.cloudnet.v2.lib.NetworkUtils; | ||
| import eu.cloudnetservice.cloudnet.v2.setup.models.GetBukkitVersion; | ||
| import org.jetbrains.annotations.Nullable; | ||
|
|
||
| import java.io.BufferedReader; | ||
| import java.io.IOException; | ||
| import java.io.InputStream; | ||
| import java.io.InputStreamReader; | ||
| import java.net.URL; | ||
| import java.net.URLConnection; | ||
| import java.util.ArrayList; | ||
|
|
||
| public class GetBukkitVersions { | ||
| private static final String versionsUrl = "https://getbukkit.org/download/spigot"; | ||
|
|
||
| /** | ||
| * Loads a list of all Spigot Versions available on getbukkit.org | ||
| * | ||
| * @param minVersion All versions bellow this version will be ignored | ||
| * @return array of versions | ||
| */ | ||
| public static GetBukkitVersion[] getVersions(@Nullable String minVersion) { | ||
| ArrayList<GetBukkitVersion> versions = new ArrayList<>(); | ||
| try { | ||
| URL url = new URL(versionsUrl); | ||
| URLConnection connection = url.openConnection(); | ||
| connection.setRequestProperty("User-Agent", NetworkUtils.USER_AGENT); | ||
| connection.connect(); | ||
|
|
||
| InputStream input = connection.getInputStream(); | ||
| try (BufferedReader reader = new BufferedReader(new InputStreamReader(input))) { | ||
| String currentVersion = null; | ||
|
|
||
| boolean exitAfter = false; //Is true when minimum version is reached | ||
| short searchFor = 0; //0 -> "Version" Text; 1 -> Actual Version; 2 -> Download Link | ||
|
|
||
| String line; | ||
| while ((line = reader.readLine()) != null) { | ||
|
There was a problem hiding this comment. make you condition right and you need no break! There was a problem hiding this comment. Whilst I appreciate your help, please give more constructive feedback. |
||
| if (line.contains("Version")) { | ||
| searchFor = 1; | ||
| continue; | ||
| } | ||
|
|
||
| if (searchFor == 1) { | ||
| int versionStart = line.indexOf(">"); | ||
| versionStart++; | ||
| int versionEnd = line.indexOf("<", versionStart); | ||
| String version = line.substring(versionStart, versionEnd); | ||
|
|
||
| currentVersion = version; | ||
| searchFor = 2; | ||
|
|
||
| if (version.equals(minVersion)) | ||
| exitAfter = true; | ||
| continue; | ||
| } | ||
|
|
||
| if (searchFor == 2) { | ||
| if (!line.contains("href=\"https://getbukkit.org/get/")) continue; | ||
|
|
||
| int linkStart = line.indexOf("\""); | ||
| linkStart++; | ||
| int linkEnds = line.indexOf("\"", linkStart); | ||
|
|
||
| String downloadPreview = line.substring(linkStart, linkEnds); | ||
| URL previewURL = new URL(downloadPreview); | ||
| GetBukkitVersion version = new GetBukkitVersion(currentVersion, previewURL); | ||
|
|
||
| versions.add(version); | ||
| searchFor = 0; | ||
| if (exitAfter) break; | ||
| } | ||
| } | ||
| } | ||
| } catch (IOException exception) { | ||
| exception.printStackTrace(); | ||
| } | ||
| return versions.toArray(new GetBukkitVersion[0]); | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the conndition right and move the return value into a temp variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whilst I appreciate your help, please give more constructive feedback.
What would be the correct condition to check for?