Add the ability to place waypoints immediately on position when holding Shift #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoyfulShush
changed the title
Member
|
Would it be better to use the last-used color instead of using the default color? |
Contributor
Author
|
Turns out that it already does that. Makes sense, since the window is only initialized once and it remembers the value of the color that was last picked by the user. I'll update the description to match. |
Rampastring
requested changes
Nov 17, 2025
Member
Rampastring
left a comment
Rampastring
left a comment
There was a problem hiding this comment.
Looks good aside from having an useless state variable in PlaceWaypointCursorAction.
Co-authored-by: Rami Pasanen <[email protected]>
Rampastring
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When holding shift, skips the dialog window and instead immediately places the next free waypoint with the
default color (none, which default to purple)last picked color.Respects used, available and max waypoints and shows the appropriate messages using the same flow as with the existing flow.