Skip to content

Fix/deprecations memory leak entitlements #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix/deprecations memory leak entitlements #2147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aad6716
Fix: Update macOS deployment target from 13.0 to 14.0
vksvicky Dec 2, 2025
636ead0
Fix: Resolve deprecation warnings and unreachable code
vksvicky Dec 2, 2025
0de7f93
Fix: Additional onChange deprecation warnings
vksvicky Dec 2, 2025
d0d2893
Fix: Add required entitlements for file access
vksvicky Dec 2, 2025
dc53fb7
Fix: Memory leak in CurrentUser.getCurrentUser()
vksvicky Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 41 additions & 21 deletions CodeEdit.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@
attributes = {
BuildIndependentTargetsInParallel = 1;
LastSwiftUpdateCheck = 1330;
LastUpgradeCheck = 1640;
LastUpgradeCheck = 2610;
TargetAttributes = {
2BE487EB28245162003F3F64 = {
CreatedOnToolsVersion = 13.3.1;
Expand Down Expand Up @@ -643,13 +643,14 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = "";
MTL_ENABLE_DEBUG_INFO = NO;
MTL_FAST_MATH = YES;
OTHER_SWIFT_FLAGS = "-D ALPHA";
RUN_DOCUMENTATION_COMPILER = YES;
SDKROOT = macosx;
STRING_CATALOG_GENERATE_SYMBOLS = YES;
SWIFT_COMPILATION_MODE = wholemodule;
SWIFT_OPTIMIZATION_LEVEL = "-O";
SYSTEM_FRAMEWORK_SEARCH_PATHS = "";
Expand All @@ -673,6 +674,7 @@
DEAD_CODE_STRIPPING = YES;
DEVELOPMENT_ASSET_PATHS = "\"CodeEdit/Preview Content\"";
DEVELOPMENT_TEAM = "";
ENABLE_APP_SANDBOX = YES;
ENABLE_HARDENED_RUNTIME = YES;
ENABLE_PREVIEWS = YES;
GENERATE_INFOPLIST_FILE = NO;
Expand All @@ -684,12 +686,14 @@
"$(inherited)",
"@executable_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = "Change in Info.plist";
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
REGISTER_APP_GROUPS = YES;
RUNTIME_EXCEPTION_ALLOW_JIT = YES;
RUNTIME_EXCEPTION_DISABLE_LIBRARY_VALIDATION = YES;
RUN_DOCUMENTATION_COMPILER = NO;
SWIFT_EMIT_LOC_STRINGS = YES;
SWIFT_OBJC_BRIDGING_HEADER = "";
Expand All @@ -715,7 +719,7 @@
"@executable_path/../Frameworks",
"@loader_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEditTests;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down Expand Up @@ -777,7 +781,7 @@
"@executable_path/../Frameworks",
"@executable_path/../../../../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit.OpenWithCodeEdit;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down Expand Up @@ -840,13 +844,14 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = "";
MTL_ENABLE_DEBUG_INFO = NO;
MTL_FAST_MATH = YES;
OTHER_SWIFT_FLAGS = "-D BETA";
RUN_DOCUMENTATION_COMPILER = YES;
SDKROOT = macosx;
STRING_CATALOG_GENERATE_SYMBOLS = YES;
SWIFT_COMPILATION_MODE = wholemodule;
SWIFT_OPTIMIZATION_LEVEL = "-O";
SYSTEM_FRAMEWORK_SEARCH_PATHS = "";
Expand All @@ -870,6 +875,7 @@
DEAD_CODE_STRIPPING = YES;
DEVELOPMENT_ASSET_PATHS = "\"CodeEdit/Preview Content\"";
DEVELOPMENT_TEAM = "";
ENABLE_APP_SANDBOX = YES;
ENABLE_HARDENED_RUNTIME = YES;
ENABLE_PREVIEWS = YES;
GENERATE_INFOPLIST_FILE = NO;
Expand All @@ -881,12 +887,14 @@
"$(inherited)",
"@executable_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = "Change in Info.plist";
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
REGISTER_APP_GROUPS = YES;
RUNTIME_EXCEPTION_ALLOW_JIT = YES;
RUNTIME_EXCEPTION_DISABLE_LIBRARY_VALIDATION = YES;
RUN_DOCUMENTATION_COMPILER = NO;
SWIFT_EMIT_LOC_STRINGS = YES;
SWIFT_OBJC_BRIDGING_HEADER = "";
Expand All @@ -912,7 +920,7 @@
"@executable_path/../Frameworks",
"@loader_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEditTests;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down Expand Up @@ -974,7 +982,7 @@
"@executable_path/../Frameworks",
"@executable_path/../../../../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit.OpenWithCodeEdit;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down Expand Up @@ -1009,7 +1017,7 @@
"@executable_path/../Frameworks",
"@executable_path/../../../../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit.OpenWithCodeEdit;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down Expand Up @@ -1044,7 +1052,7 @@
"@executable_path/../Frameworks",
"@executable_path/../../../../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit.OpenWithCodeEdit;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down Expand Up @@ -1108,13 +1116,14 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = "";
MTL_ENABLE_DEBUG_INFO = NO;
MTL_FAST_MATH = YES;
OTHER_SWIFT_FLAGS = "-D ALPHA";
RUN_DOCUMENTATION_COMPILER = YES;
SDKROOT = macosx;
STRING_CATALOG_GENERATE_SYMBOLS = YES;
SWIFT_COMPILATION_MODE = wholemodule;
SWIFT_OPTIMIZATION_LEVEL = "-O";
SYSTEM_FRAMEWORK_SEARCH_PATHS = "";
Expand All @@ -1139,6 +1148,7 @@
DEAD_CODE_STRIPPING = YES;
DEVELOPMENT_ASSET_PATHS = "\"CodeEdit/Preview Content\"";
DEVELOPMENT_TEAM = "";
ENABLE_APP_SANDBOX = YES;
ENABLE_HARDENED_RUNTIME = YES;
ENABLE_PREVIEWS = YES;
GENERATE_INFOPLIST_FILE = NO;
Expand All @@ -1150,12 +1160,14 @@
"$(inherited)",
"@executable_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = "Change in Info.plist";
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
REGISTER_APP_GROUPS = YES;
RUNTIME_EXCEPTION_ALLOW_JIT = YES;
RUNTIME_EXCEPTION_DISABLE_LIBRARY_VALIDATION = YES;
RUN_DOCUMENTATION_COMPILER = NO;
SWIFT_EMIT_LOC_STRINGS = YES;
SWIFT_OBJC_BRIDGING_HEADER = "";
Expand All @@ -1181,7 +1193,7 @@
"@executable_path/../Frameworks",
"@loader_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEditTests;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down Expand Up @@ -1243,7 +1255,7 @@
"@executable_path/../Frameworks",
"@executable_path/../../../../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit.OpenWithCodeEdit;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down Expand Up @@ -1312,13 +1324,14 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = "";
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
MTL_FAST_MATH = YES;
ONLY_ACTIVE_ARCH = YES;
RUN_DOCUMENTATION_COMPILER = YES;
SDKROOT = macosx;
STRING_CATALOG_GENERATE_SYMBOLS = YES;
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SYSTEM_FRAMEWORK_SEARCH_PATHS = "";
Expand Down Expand Up @@ -1378,12 +1391,13 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = "";
MTL_ENABLE_DEBUG_INFO = NO;
MTL_FAST_MATH = YES;
RUN_DOCUMENTATION_COMPILER = YES;
SDKROOT = macosx;
STRING_CATALOG_GENERATE_SYMBOLS = YES;
SWIFT_COMPILATION_MODE = wholemodule;
SWIFT_OPTIMIZATION_LEVEL = "-O";
SYSTEM_FRAMEWORK_SEARCH_PATHS = "";
Expand All @@ -1407,6 +1421,7 @@
DEAD_CODE_STRIPPING = YES;
DEVELOPMENT_ASSET_PATHS = "\"CodeEdit/Preview Content\"";
DEVELOPMENT_TEAM = "";
ENABLE_APP_SANDBOX = YES;
ENABLE_HARDENED_RUNTIME = YES;
ENABLE_PREVIEWS = YES;
GENERATE_INFOPLIST_FILE = NO;
Expand All @@ -1418,12 +1433,14 @@
"$(inherited)",
"@executable_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = "Change in Info.plist";
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
REGISTER_APP_GROUPS = YES;
RUNTIME_EXCEPTION_ALLOW_JIT = YES;
RUNTIME_EXCEPTION_DISABLE_LIBRARY_VALIDATION = YES;
RUN_DOCUMENTATION_COMPILER = NO;
SWIFT_EMIT_LOC_STRINGS = YES;
SWIFT_OBJC_BRIDGING_HEADER = "";
Expand All @@ -1448,6 +1465,7 @@
DEAD_CODE_STRIPPING = YES;
DEVELOPMENT_ASSET_PATHS = "\"CodeEdit/Preview Content\"";
DEVELOPMENT_TEAM = "";
ENABLE_APP_SANDBOX = YES;
ENABLE_HARDENED_RUNTIME = YES;
ENABLE_PREVIEWS = YES;
GENERATE_INFOPLIST_FILE = NO;
Expand All @@ -1459,12 +1477,14 @@
"$(inherited)",
"@executable_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = "Change in Info.plist";
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
REGISTER_APP_GROUPS = YES;
RUNTIME_EXCEPTION_ALLOW_JIT = YES;
RUNTIME_EXCEPTION_DISABLE_LIBRARY_VALIDATION = YES;
RUN_DOCUMENTATION_COMPILER = NO;
SWIFT_EMIT_LOC_STRINGS = YES;
SWIFT_OBJC_BRIDGING_HEADER = "";
Expand All @@ -1490,7 +1510,7 @@
"@executable_path/../Frameworks",
"@loader_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEditTests;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand All @@ -1517,7 +1537,7 @@
"@executable_path/../Frameworks",
"@loader_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 13.0;
MACOSX_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEditTests;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down
2 changes: 1 addition & 1 deletion CodeEdit.xcodeproj/xcshareddata/xcschemes/CodeEdit.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "2600"
LastUpgradeVersion = "2610"
version = "1.7">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
2 changes: 1 addition & 1 deletion CodeEdit.xcodeproj/xcshareddata/xcschemes/OpenWithCodeEdit.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "2600"
LastUpgradeVersion = "2610"
wasCreatedForAppExtension = "YES"
version = "2.0">
<BuildAction
Expand Down
12 changes: 8 additions & 4 deletions CodeEdit/CodeEdit.entitlements
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,18 @@
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>com.apple.security.app-sandbox</key>
<true/>
<key>com.apple.security.files.user-selected.read-write</key>
<true/>
<key>com.apple.security.files.bookmarks.app-scope</key>
<true/>
<key>com.apple.security.network.client</key>
<true/>
<key>com.apple.security.application-groups</key>
<array>
<string>app.codeedit.CodeEdit.shared</string>
<string>$(TeamIdentifierPrefix)</string>
</array>
<key>com.apple.security.cs.allow-jit</key>
<true/>
<key>com.apple.security.cs.disable-library-validation</key>
<true/>
</dict>
</plist>
2 changes: 1 addition & 1 deletion CodeEdit/Features/ActivityViewer/Notifications/TaskNotificationView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ struct TaskNotificationView: View {
}
}
.animation(.easeInOut, value: notification)
.onChange(of: taskNotificationHandler.notifications) { newValue in
.onChange(of: taskNotificationHandler.notifications) { _, newValue in
withAnimation {
notification = newValue.first
}
Expand Down
2 changes: 1 addition & 1 deletion CodeEdit/Features/ActivityViewer/Notifications/TaskNotificationsDetailView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ struct TaskNotificationsDetailView: View {
}
.padding(15)
.frame(minWidth: 320)
.onChange(of: taskNotificationHandler.notifications) { newValue in
.onChange(of: taskNotificationHandler.notifications) { _, newValue in
if selectedTaskNotificationIndex >= newValue.count {
selectedTaskNotificationIndex = 0
}
Expand Down
6 changes: 3 additions & 3 deletions CodeEdit/Features/CEWorkspaceSettings/Views/EnvironmentVariableListItem.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ struct EnvironmentVariableListItem: View {
.autocorrectionDisabled()
.labelsHidden()
}
.onChange(of: isKeyFocused) { isFocused in
.onChange(of: isKeyFocused) { _, isFocused in
if isFocused {
if selectedEnvID != environmentVariable.id {
selectedEnvID = environmentVariable.id
Expand All @@ -62,10 +62,10 @@ struct EnvironmentVariableListItem: View {
}
}
}
.onChange(of: key) { newValue in
.onChange(of: key) { _, newValue in
environmentVariable.key = newValue
}
.onChange(of: value) { newValue in
.onChange(of: value) { _, newValue in
environmentVariable.value = newValue
}
}
Expand Down
2 changes: 1 addition & 1 deletion CodeEdit/Features/CodeEditUI/Views/KeyValueTable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ struct KeyValueTable<Header: View, ActionBarView: View>: View {
}
selection = []
}
.onChange(of: items) { newValue in
.onChange(of: items) { _, newValue in
updateTableItems(newValue)
}
}
Expand Down
4 changes: 2 additions & 2 deletions CodeEdit/Features/CodeEditUI/Views/WorkspacePanelTabBar.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,10 +281,10 @@ struct WorkspacePanelTabBar<Tab: WorkspacePanelTab>: View {
self.tabWidth[tab] = (position == .top) ? geometry.size.width : geometry.size.height
self.tabLocations[tab] = geometry.frame(in: .global)
}
.onChange(of: geometry.frame(in: .global)) { newFrame in
.onChange(of: geometry.frame(in: .global)) { _, newFrame in
self.tabLocations[tab] = newFrame
}
.onChange(of: geometry.size.width) { newWidth in
.onChange(of: geometry.size.width) { _, newWidth in
self.tabWidth[tab] = newWidth
}
}
Expand Down
Loading