Fix: Prevent git popup when Source Control is disabled (#2138) #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Fixed issue where CodeEdit would show "The 'git' command requires the command line developer tools. Would you like to install the tools now?" popup on every app launch, even when Source Control was completely disabled in Settings. Issue Analysis: - WorkspaceView.swift was unconditionally calling git operations (refreshRemotes and refreshStashEntries) on every workspace launch - These git commands triggered macOS to show the Command Line Developer Tools installation popup if git wasn't installed - The operations ran regardless of the sourceControlIsEnabled setting Solution: - Added guard statement to check sourceControlIsEnabled before running git operations in the .task block - Now git commands only execute when Source Control is enabled in Settings - Also updated onChange syntax to modern two-parameter form Result: - Users who disable Source Control no longer see the git tools popup - Git operations still work normally when Source Control is enabled - Popup behavior now respects user preferences as expected Fixes CodeEditApp#2138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue where CodeEdit would show "The 'git' command requires the command line developer tools. Would you like to install the tools now?" popup on every app launch, even when Source Control was completely disabled in Settings.
Description
Result:
Related Issues
Checklist
Screenshots