Fixed (de)serialization to include activation function. #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes CodingTrain#96 by using a `replacer` on serialization to preserve the activation function as a string. On deserialization the function string is `eval()`-ed. This is dangerous as malicious code could be executed. Might be possible to port this to using `new Function()` instead.
enginefeeder101
added a commit
to enginefeeder101/Toy-Neural-Network-JS
that referenced
this pull request
Mar 10, 2018
The (de)serialzation functions already have all the code needed to make a deep copy of the NeuralNetwork. This commit also adds a test for the `Matrix.copy()` function. This also copies the learning rate and if CodingTrain#97 is merged the activation function is copied as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #96 by using a
replaceron serialization to preserve the activation function as a string.On deserialization the function string is
eval()-ed. This is dangerous as malicious code could beexecuted. Might be possible to port this to using
new Function()instead.