test(lcms): disperse PR #232 review tests (B1–B7) into per-subject suites - #314
Merged
Merged
Conversation
PiTrem
changed the base branch from
fix/cv-density-submit-factor
to
231-display-lcms-data
June 29, 2026 11:32
…ites The B1–B7 review regression tests lived in one PR-named file (pr232_review_blocking.test.tsx). Move each into the test file that owns the code it guards, matching the repo's subject-based test layout: - B1 peak-add on a non-LCMS layout -> sagas/saga_ui_lcms.test.tsx - B2 getArea on cumulative-k data -> helpers/integration.test.tsx - B3 getAbsoluteArea from raw y -> helpers/integration.test.tsx - B4 Convert2Peak honours stored peaks -> helpers/chem.test.tsx - B7 convertThresEndPts precondition -> helpers/chem.test.tsx - B5 CV current-density chart factor -> components/d3_multi/multi_focus.test.js (new) - B7 drawBar empty-endpoint guard -> components/d3_line_rect.test.js B6 (UV-Vis update-path guard) is dropped: its test only re-implemented the source inline (ViewerLineRect is not exported), so it guarded nothing in the real component. Tracked as a follow-up needing a testable seam. B5's submit/export factor (computeCvYScaleFactor) is already covered in components/cmd_bar/r05_submit_btn.test.js, so it is not duplicated here. No behaviour change — tests only. All moved assertions stay green. refs #232
PiTrem
force-pushed
the
test/disperse-pr232-blocking
branch
from
June 29, 2026 11:34
2d6e367 to
887b289
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #313 (base =
fix/cv-density-submit-factor). Will retarget to231-display-lcms-dataonce #313 merges. Tests only — no behaviour change.What
The B1–B7 review regression tests were carried in a single PR-named file,
src/__tests__/units/pr232_review_blocking.test.tsx, which served its purpose as the red→green proof for #232's blockers. As a permanent fixture it fought the repo's subject-based test layout. This PR moves each test into the suite that owns the code it guards and deletes the combined file.EDITPEAK.ADD_POSITIVEsagas/saga_ui_lcms.test.tsx(alongside the existing PEAK_ADD LCMS cases)getAreaon cumulative-k(NMR/CV) datahelpers/integration.test.tsxgetAbsoluteAreafrom rawyhelpers/integration.test.tsxConvert2Peakhonours stored LC/MS peaks + offsethelpers/chem.test.tsxconvertThresEndPtsempty-on-cleared preconditionhelpers/chem.test.tsxcomponents/d3_multi/multi_focus.test.js(new)drawBarempty-endpoint guardcomponents/d3_line_rect.test.jsTwo deliberate changes from a straight move
ViewerLineRectisn't exported), so it exercised no real component code — a tautology that gives false confidence in a permanent suite. Removed and tracked as a follow-up: it needs a testable seam (exportViewerLineRect, or extract the uvvis-seed builder) before it can guard the realcomponentDidUpdateguard.computeCvYScaleFactoris already covered incomponents/cmd_bar/r05_submit_btn.test.js(added in fix(cv): apply CV current-density factor once on submit/export (B5 remainder, for #232) #313). The B5 test moved here covers the chart factor (multi_focus.computeYTransformFactor), the other call site.Test
All moved assertions stay green on the branch head:
refs #232