Skip to content

Hide NavigationBar from Android popups #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Hide NavigationBar from Android popups #2866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CommunityToolkit.Maui/Views/Popup/PopupPage.shared.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ public PopupPage(Popup popup, IPopupOptions? popupOptions)
this.SetBinding(BackgroundColorProperty, static (IPopupOptions options) => options.PageOverlayColor, source: popupOptions, mode: BindingMode.OneWay);

Shell.SetPresentationMode(this, PresentationMode.ModalNotAnimated);
Shell.SetNavBarIsVisible(this, false);
Copy link

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a platform-specific approach since the title mentions 'Android popups' but this change affects all platforms. Use On<Android>().SetNavBarIsVisible(this, false) to target only Android, similar to how the iOS-specific code is handled on line 69.

Suggested change
Shell.SetNavBarIsVisible(this, false);
On<Android>().SetNavBarIsVisible(this, false);

Copilot uses AI. Check for mistakes.

Copy link
Collaborator

@TheCodeTraveler TheCodeTraveler Aug 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bijington - do we want to hide the Navigation Bar only on Android, or do we want to hide it on iOS too?

How does this look on iOS now compared to its previous/current implementation?

On<iOS>().SetModalPresentationStyle(UIModalPresentationStyle.OverFullScreen);
}

Expand Down
Loading