CMP-3847: Added TestOperatorResourceLimitsConfigurable tests operator's resource limits and requests can be configured via patching the deployment by taimurhafeez · Pull Request #1084 · ComplianceAsCode/compliance-operator

taimurhafeez · 2026-02-11T14:15:37Z

TestOperatorResourceLimitsConfigurable verifies that the Compliance Operator's CPU and memory resource limits can be dynamically configured by patching its Deployment object. This ensures that cluster administrators can tune the operator's resource consumption to meet their cluster's needs.

Can be executed:
make e2e-serial E2E_GO_TEST_FLAGS="-v -run TestOperatorResourceLimitsConfigurable"

Expected Output:

=== RUN   TestOperatorResourceLimitsConfigurable
    main_test.go:2185: Verifying default resource limits for compliance-operator
    main_test.go:2215: Patching deployment with new resource limits
2026/02/11 15:44:09 Deployment available (1/1)
    main_test.go:2298: Verifying new resource limits on operator pod
    main_test.go:2335: Successfully verified operator resource limits are configurable
    main_test.go:2248: Restoring original resource limits
2026/02/11 15:44:15 Deployment available (1/1)
--- PASS: TestOperatorResourceLimitsConfigurable (10.75s)
PASS

Used with PR-960.
Assisted by Claude.

…hat Operator's resource limits and requests can be configured via patching the deployment

openshift-ci · 2026-02-11T14:15:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: taimurhafeez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [taimurhafeez]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-02-11T14:15:48Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2026-02-11T14:17:23Z

@taimurhafeez: No Jira issue with key FCMP-3847 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-02-11T14:20:17Z

@taimurhafeez: This pull request references CMP-3847 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

github-actions · 2026-02-11T14:23:18Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1084-2d058b68a1b60439aba6f67d058a512680bafc52

github-actions · 2026-02-12T12:29:48Z

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1084-40a43b8d5f74029e9c585955d9b40ccb45d28c53

openshift-ci · 2026-02-12T13:59:31Z

@taimurhafeez: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-rosa	`40a43b8`	link	true	`/test e2e-rosa`
ci/prow/e2e-aws-parallel-arm	`40a43b8`	link	true	`/test e2e-aws-parallel-arm`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rhmdnd

Couple comments on testing OLM behavior and some recommendations for restoring the defaults.

Thanks for the PR!

rhmdnd · 2026-03-05T21:21:27Z

tests/e2e/serial/main_test.go

+							"resources": {
+								"limits": {
+									"cpu": "200m",
+									"memory": "500Mi"


If we change these default values in the CSV, the test will revert to a non-default value, right?

We might want to grab the original values and restore those at the end of the test (since these can change).

Oh - I suppose we're asserting these are the default values above. In that case, the test would already fail.

Maybe we can have the default values as constants?

rhmdnd · 2026-03-05T21:25:14Z

tests/e2e/serial/main_test.go

+	oldPodUID := podList.Items[0].UID
+
+	// Apply the patch
+	err = f.Client.Patch(context.TODO(), deployment, client.RawPatch(types.StrategicMergePatchType, patchData))


Will this change persist? Or will OLM revert the operator limits back to what's in the CSV?

https://github.com/ComplianceAsCode/compliance-operator/blob/master/bundle/manifests/compliance-operator.clusterserviceversion.yaml#L1369-L1375

If so, we may need to adjust the test to patch the CSV?

rhmdnd · 2026-03-05T21:26:23Z

tests/e2e/serial/main_test.go

+	if len(podList.Items) == 0 {
+		t.Fatal("no compliance-operator pods found before patch")
+	}
+	oldPodUID := podList.Items[0].UID


This might break in the off chance the operator is rolling out an update and there is one terminating pod and one running pod. Checking the pod name, it's state, and the list length == 1 might make this more robust.

rhmdnd · 2026-03-05T21:26:41Z

tests/e2e/serial/main_test.go

 //							NodeSelector: workerNodesLabel,
 //							ComplianceScanSettings: compv1alpha1.ComplianceScanSettings{
 //								Debug: true,
-//							},


nit: unrelated whitespace change.

First version of TestOperatorResourceLimitsConfigurable that tests t…

2d058b6

…hat Operator's resource limits and requests can be configured via patching the deployment

openshift-ci bot added the do-not-merge/work-in-progress label Feb 11, 2026

openshift-ci bot added the approved label Feb 11, 2026

openshift-ci-robot added the jira/valid-reference label Feb 11, 2026

taimurhafeez marked this pull request as ready for review February 11, 2026 16:22

openshift-ci bot removed the do-not-merge/work-in-progress label Feb 11, 2026

openshift-ci bot requested review from mrogers950 and xiaojiey February 11, 2026 16:22

Added UID to ensure resources are being checked for the correct pod

40a43b8

rhmdnd requested changes Mar 5, 2026

View reviewed changes

openshift-ci bot assigned rhmdnd Mar 5, 2026

Conversation

taimurhafeez commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Feb 11, 2026

Uh oh!

openshift-ci bot commented Feb 11, 2026

Uh oh!

openshift-ci-robot commented Feb 11, 2026

Uh oh!

openshift-ci-robot commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

openshift-ci bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhmdnd left a comment

Choose a reason for hiding this comment

Uh oh!

rhmdnd Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

rhmdnd Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

rhmdnd Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

rhmdnd Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

rhmdnd Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

taimurhafeez commented Feb 11, 2026 •

edited

Loading

openshift-ci bot commented Feb 12, 2026 •

edited

Loading