Skip to content

Conversation

@Will-Hellinger
Copy link

Someone will need to double check this LOL

  • Migrate to ruff
  • Migrate to uv for docker image
  • Fix csh_ldap not working
  • Optimizations via small caches

Copy link
Collaborator

@mxmeinhold mxmeinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took a look through, though I found it hard to read through all the formatting. Glancing through commits, seemed like there wasn't much in code changes, more in deps and CI?

Have a couple comments

@Will-Hellinger Will-Hellinger marked this pull request as draft September 23, 2025 19:28
@Will-Hellinger Will-Hellinger marked this pull request as ready for review October 27, 2025 21:37
Copy link
Member

@pikachu0542 pikachu0542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, need to run it locally to test

Copy link
Member

@pikachu0542 pikachu0542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to get it running locally, and it works. However, I cant seem to figure out how to test the mock user functionality, and with no open packets, I cant verify that the main functionality still works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants