feat(kernel-ui): Use MetaMask extension's design system - #577
Merged
Conversation
…n System integration
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
sirtimid
marked this pull request as ready for review
July 23, 2025 13:28
Contributor
Author
|
@SocketSecurity ignore-all |
sirtimid
enabled auto-merge (squash)
July 23, 2025 13:45
sirtimid
disabled auto-merge
July 23, 2025 22:35
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
sirtimid
commented
Jul 24, 2025
| import * as React from "react"; | ||
| import { composeRefs } from "@radix-ui/react-compose-refs"; | ||
| -import { Fragment as Fragment2, jsx } from "react/jsx-runtime"; | ||
| +import { Fragment as Fragment2, jsx } from "react/jsx-runtime.js"; |
Contributor
Author
There was a problem hiding this comment.
This is required because react 16 and 17 don't specify jsx-runtime in exports field react/react#20235 We could also patch reacts package.json but this seemed sufficient. It can be removed once we upgrade to react 18 and on.
sirtimid
enabled auto-merge (squash)
July 25, 2025 14:43
grypez
requested changes
Aug 11, 2025
grypez
left a comment
grypez
left a comment
Collaborator
There was a problem hiding this comment.
Hooray!
- extension auto-rebuild
- kernel-ui tests now consistently locate components by test-id
Notes:
- Some of the files grow unwieldy, especially with the styles written directly into them. I give some reuse suggestions that can easily fit in this PR, but none of them is necessary for approval.
- I don't think we need the markdown file
sirtimid
disabled auto-merge
August 11, 2025 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #548
Use MetaMask extension's design system instead of custom components which also introduces the beloved tailwind :)
Additionally, the
watchcommand of theextensionpackage now watches for changes ofkernel-uipackage.