Fix url list processing#66
Open
zemanel wants to merge 1 commit intoContentMine:masterfrom
repositive:master
Open
Fix url list processing#66zemanel wants to merge 1 commit intoContentMine:masterfrom repositive:master
zemanel wants to merge 1 commit intoContentMine:masterfrom
repositive:master
Conversation
Member
|
Thanks for this, I will test and merge asap |
|
I see this hasn't been merged, but has the fix been included some other way? I can't seem to reproduce the problem. (If it has been fixed, can this PR be closed?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When specifying a list of urls to process, through the
urllistfile param, the last url is not processed.I believe its a race condition, whereas
finish()is called on asetTimeout()tick, without the last url having finished processing.I removed an
finishcall as it will be called on the ensuing ticks.