Skip to content

Conversation

johnhoffm
Copy link
Contributor

Some modded items extend PotionItem, but aren't really potions. The best example of this is the jelly bean from Alex's Caves where it doesn't make sense that it drains and becomes a bottle. I think adding an item tag is the best way to prevent this in the general case. This also could have worked for the tinker's construct buckets in #6316, #4124

PR targets 1.20.1 since this is where I see the problem, but could also work on other versions.

Without tag:
Throwing a jelly bean on an item drain, drains it and produces a bottle.
image

With tag applied to alexscaves:jelly_bean:
The recipe does not exist, and jelly beans do not drain into an item drain.

@simibubi simibubi merged commit c4c508d into Creators-of-Create:mc1.20.1/dev Aug 27, 2025
@simibubi
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants