Skip to content

Document Skipped Tests - #118

Draft
RadWolfie wants to merge 5 commits into
Cxbx-Reloaded:masterfrom
RadWolfie:impl-tests-skipped
Draft

Document Skipped Tests#118
RadWolfie wants to merge 5 commits into
Cxbx-Reloaded:masterfrom
RadWolfie:impl-tests-skipped

Conversation

@RadWolfie

Copy link
Copy Markdown
Member

The following API tests are being skipped for now:

This pull request is currently a draft in case there are more tests that can be skipped. There are other API exports that are only testable on dev/debug kit hardware. However, they cannot be added here until there is a reliable workaround.

TEST_BEGIN();

// HalInitiateShutdown will shut down the system
// TODO: Need a config variable to determine allow to test or not

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO: Need a config variable to determine allow to test or not
// TODO: Need a config variable to determine whether or not to allow the test

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I thought I had this vetted by my assistant. However, I will change the sentence to ""We need a configuration variable to determine if testing is allowed" later on.

TEST_BEGIN();

// HalReturnToFirmware will reboot/shutdown
// TODO: Need a config variable to determine allow to test or not

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO: Need a config variable to determine allow to test or not
// TODO: Need a config variable to determine whether or not to allow the test

@ergo720

ergo720 commented Jul 15, 2026

Copy link
Copy Markdown
Member

There are other API exports that are only testable on dev/debug kit hardware. However, they cannot be added here until there is a reliable workaround. https://github.com/ergo720/nboxkrnl/blob/66e2193a61d277049b18b08df08bf4447dde843f/nboxkrnl/ke/kernel.cpp#L50 I know that XboxKrnlVersion exposes a "debug/devkit kernel" flag in its Qfe member, would that be a reliable workaround here?

@RadWolfie

Copy link
Copy Markdown
Member Author

That's highly unlikely. We lack the exported API list from Chihiro, and its QFE member does not contain a debug/devkit flag (apart from the Chihiro flag itself). Additionally, homebrew kernels can implement these same features, which makes this approach unreliable.

I made a commit to check if these APIs are implemented; however, they will not work because the Xbox kernel prevents the XBE from running. A workaround is required on top of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants