Add XeImageFileName Tests - #119
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minimum file path required to function is
\Device\x\x, as the file extension isn't necessary to load the file.The root directory
\Deviceis mandatory to directly access the XBE file. This is followed by the device node, where an optional partition and subfolder path may be necessary depending on the directory from which the XBE file is read. Finally, the XBE file name is required to load the executable from the kernel side.Some of the tests created by PatrickvL are performed first as a prerequisite. I then added new tests to validate the minimum file path behavior stated above. However, these new tests do not check for forbidden or acceptable characters besides the null terminator.
This pull request adds new tests and further verification checks on top of PatrickvL's #112 pull request.