-
-
Notifications
You must be signed in to change notification settings - Fork 214
Add alpine go 1.21 image #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add alpine go 1.21 image #1920
Conversation
Signed-off-by: bandhan-majumder <[email protected]>
Signed-off-by: bandhan-majumder <[email protected]>
@@ -0,0 +1,42 @@ | |||
# Base-image | |||
FROM golang:1.21-alpine AS base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if this argument could be templatised with a build-arg and we execute the same Dockerfile a few times with different Go versions? @malice00 any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably can. Might need some tweaking in the workflows & actions and add another parameter or something like that. @bandhan-majumder you want to give it a try, or do you want me to look at it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I may need some time as my exams are going on. If there is no urgency of this, I can take a look after some days. Also, the argument will have to templatised in two places I think, in the base image and in the label org.opencontainers.docker.cmd
. Please correct me if I am wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not urgent at all.
@bandhan-majumder Whenever you continue this, I have made MAJOR changes to all Dockerfiles to have them use a self-hosted caching proxy for binaries (Nexus). Please take a look at the other files and change accordingly. |
Golang 1.21 alpine image is added