fix: correct naming of aggregated results when using variables #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using aggregates with a variable (e.g., `{ v: "?v$sum" }`) would incorrectly generate SPARQL queries like "(SUM(?v) AS ?v)", leading to invalid queries in stricter engines like GraphDB. The naming convention is now adjusted to generate unique variable names, such as "(SUM(?v) AS ?v_sum)". This was already the case when using expressions such as "$schema:value$sum", but it didn't apply to variables. This commit fixes that behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using aggregates with a variable (e.g.,
{ v: "?v$sum" }) would "incorrectly" generate SPARQL queries like:(SUM(?v) AS ?v). While technically accepted/ignored by Virtuoso, it causes errors with stricter engines like GraphDB.The naming convention is now adjusted to generate unique variable names, such as
(SUM(?v) AS ?v_sum).It was already the case when using expressions such as
$schema:value$sum, but it didn't apply to variables.This commit fixes that behavior.
✔ DBpedia list of cities (proto)
✔ DBpedia list of cities and regions (jsonld)
✔ DBpedia grunge bands
✔ DBpedia genres with bands
✔ Aggregates
✔ No lang tag
✔ Duplicate variable name
✔ List-required fieds
✔ Library limit (103ms)
─
9 tests passed