-
Notifications
You must be signed in to change notification settings - Fork 9
Network Support #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jpalm3r
wants to merge
82
commits into
main
Choose a base branch
from
japr/network-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Network Support #586
Changes from all commits
Commits
Show all changes
82 commits
Select commit
Hold shift + click to select a range
a76005c
Add NetworkModelResult and supporting classes for network data handling
jpalm3r e4d9362
Simplify parsing logic
jpalm3r d0c0f92
feat: Add NetworkModelResult for handling network data in model skill
jpalm3r 91d4513
small fixes
jpalm3r 3d7df6c
feat: Add NodeModelResult and NodeObservation for network node handling
jpalm3r 1fc1ecf
feat: Add extract_multiple method for batch extraction of NodeModelRe…
jpalm3r 35882ab
feat: Enhance matching functionality to support NodeModelResult and N…
jpalm3r 5a692ef
feat: Update matching logic to extract observations from NetworkModel…
jpalm3r e15ae63
feat: Add NetworkObservation class for handling collections of node o…
jpalm3r 1219a51
Fix test
jpalm3r 98f8a80
Importing network test data
jpalm3r 91daa72
feat: Update observation handling to include NodeObservation and adju…
jpalm3r 26a6d45
feat: Simplify node retrieval in NodeModelResult and enhance coordina…
jpalm3r 89d4925
feat: Enhance time coordinate handling in NetworkModelResult and impr…
jpalm3r caeee13
feat: Refactor observation handling to support network geometry and s…
jpalm3r c8c3ebd
refactor: Simplify node retrieval in NodeObservation by removing unne…
jpalm3r f826ea5
Update src/modelskill/matching.py
jpalm3r 87e1335
commit with errors
jpalm3r a4476ad
Fix mypy issues. Introduce Nework1D protocol
jpalm3r 0966458
Removing NetworkObservation
jpalm3r 4e5cd78
refactor: streamline NetworkModelResult extraction method by removing…
jpalm3r 0f5af4d
refactor: simplify observation matching logic in _match_single_obs fu…
jpalm3r d32e337
fix: add assertion message for non-empty datetime indices in _get_glo…
jpalm3r 636bc0f
test: add unit tests for NetworkModelResult and NodeObservation classes
jpalm3r 6bfa6bc
refactor: update notebook to use new network dataset and remove obsol…
jpalm3r f91a4df
Rename notebook
jpalm3r e42c69e
Enhance NodeObservation to support multiple nodes and auto-assign items
jpalm3r 4cc16bf
Create MultiNodeObservation
jpalm3r dd91c65
refactor: streamline MultiNodeObservation initialization and enhance …
jpalm3r 6298695
Add basic tests
jpalm3r 902551b
feat: add validation function for network data and enhance NetworkTyp…
jpalm3r c77e86c
Add aux_item in NetworkModelResult
jpalm3r 197e01f
merge latest changes
jpalm3r 3cd7404
Removing obsolete tests
jpalm3r eb57ed2
feat: enhance NodeObservation and TimeSeries classes with Self type h…
jpalm3r 6e4fc6b
Improting Self from typing_extension
jpalm3r 4bded79
fix: correct typo in FieldTypes definition in matching.py
jpalm3r 4fd5888
feat: add Self type hint and instance creation method to NodeModelResult
jpalm3r 45e21fa
fix: remove NodeModelResult from Timeseries documentation
jpalm3r 8d7c66d
Improving ValueError message
jpalm3r 75a5db8
fix test valueerror message
jpalm3r 2606a27
refactor: replace NETWORK geometry type with NODE in relevant modules
jpalm3r 7b55d95
feat: handle NODE geometry type in TimeSeries class for data conversion
jpalm3r c1b505c
typo
jpalm3r ac09177
Removing some Optional statements
jpalm3r ad757a5
Replacing All Optional[...] statements
jpalm3r c023fb1
unused import
jpalm3r b124569
Replace assert by if... raise ValueError()
jpalm3r 3deeeac
Updating obsolete tests
jpalm3r ac0da42
Refactor time series alignment: move align_data and helper functions …
jpalm3r 1a98701
Simplifying tests.
jpalm3r 8c48d5d
Refactor type hints: replace Optional with union types for improved c…
jpalm3r 8ec880d
leftovers
jpalm3r 769f1e2
Fix mypy error
jpalm3r 8f47b36
Remove obsolete test
jpalm3r a01c696
Remove redundant check
jpalm3r 3a4deca
Correct type.
jpalm3r 3090bf1
Remove legacy Geometry.Network instances
jpalm3r f49d955
Newer tests for matching network results
jpalm3r 82e50f2
Adding test for wrong matching
jpalm3r f65c833
Typo
jpalm3r 1ae8fdc
Merge changes after round of review
jpalm3r 5e82a12
Fix network validation
jpalm3r 1455362
remove empty step in notebook
jpalm3r ca0b332
Remove empty cell
jpalm3r 82a619b
Fix tests
jpalm3r 467989e
remove detailed docstring
jpalm3r 80f50b8
Including mapping as nodes argument
jpalm3r 140ae33
Make MultiNodeObservation a Collection
jpalm3r eb49cc9
fix contains from MultiNodeObservation
jpalm3r 3a64c37
improve notebook
jpalm3r e366942
Replace MultiNodeObservation by classmethod
jpalm3r 3070b07
Remove unused import
jpalm3r 4d130a5
Replace MultiNodeObservation for class method in NodeObservation
jpalm3r bf0296a
Save new nb
jpalm3r ceac146
Include csv to read a point
jpalm3r f11fb31
Refactor NodeObservation.from_multiple to handle optional data and im…
jpalm3r 8f0dc68
Improving notebook and comitting test sensor data
jpalm3r 369ba44
Including overload
jpalm3r aba3c59
comment out script for saving test data
jpalm3r 9c054f2
Including new tests
jpalm3r 6104e77
Merge pull request #588 from DHI/japr/multinodeobs
jpalm3r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.