Remove ResetRequired condition in SPDM 1.3 for set_key_pair_info_ack #3256
+40
−172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
approved these changes
Oct 11, 2025
steven-bellock
requested changes
Oct 11, 2025
| need_reset = libspdm_is_capabilities_flag_supported( | ||
| spdm_context, false, 0, | ||
| SPDM_GET_CAPABILITIES_RESPONSE_FLAGS_CERT_INSTALL_RESET_CAP); | ||
| need_reset = false; |
There was a problem hiding this comment.
The header documentation for libspdm_write_key_pair_info / need_reset needs to be updated to reflect this new behavior.
fix DMTF#3206 Signed-off-by: Aaron Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3206