Skip to content

[Snyk] Upgrade mocha from 10.8.2 to 11.7.1 #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Upgrade mocha from 10.8.2 to 11.7.1 #1701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/hardhat-truffle5/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"eslint-plugin-no-only-tests": "3.0.0",
"eslint-plugin-prettier": "3.4.0",
"hardhat": "workspace:^2.6.4",
"mocha": "^10.0.0",
"mocha": "^11.7.1",
Copy link

@gemini-code-assist gemini-code-assist bot Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Upgrading mocha to a new major version (v11) introduces a higher minimum Node.js version requirement. Mocha v11 requires Node.js v18.12.0 or newer, or v20.6.0 or newer.

While the development environment seems to use a compatible Node.js version, this package does not declare its supported Node.js versions. To prevent potential runtime issues for consumers of @nomiclabs/hardhat-truffle5 on older Node.js versions, it's highly recommended to add an engines field to package.json.

For example:

"engines": {
  "node": ">=18.12.0"
}

This will ensure that npm or yarn will show a warning if the package is installed on an incompatible Node.js version.

"prettier": "3.5.3",
"rimraf": "^6.0.1",
"ts-node": "^10.8.0",
Expand Down
Loading