-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Upgrade hardhat from 2.26.3 to 3.0.1 #1708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade hardhat from 2.26.3 to 3.0.1. See this package in npm: hardhat See this project in Snyk: https://app.snyk.io/org/dargon789/project/493afec9-46ee-406c-b759-34d7a4fd4246?utm_source=github&utm_medium=referral&page=upgrade-pr
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request automates a critical dependency update to enhance the project's security posture and ensure compatibility with the latest features and fixes. It focuses on bringing the hardhat
package to its most recent stable major version, which is essential for maintaining a robust and secure development environment.
Highlights
- Dependency Upgrade: Upgraded the
hardhat
dependency from version2.26.3
to3.0.1
. - Security Fixes: This upgrade addresses two medium-severity vulnerabilities: a Cross-site Scripting (XSS) vulnerability (SNYK-JS-COOKIE-8163060) and a Symlink Attack vulnerability (SNYK-JS-TMP-11501554).
- Major Version Change: This is a major version upgrade for
hardhat
, which may introduce breaking changes. Review of thehardhat
release notes is recommended to assess potential impacts.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request from Snyk upgrades the hardhat
development dependency to version 3.0.1
to address security vulnerabilities. While this is an important update, it's a major version change. My review has identified a critical issue: the peerDependencies
for hardhat
in package.json
has not been updated accordingly. This will cause dependency conflicts and likely break the plugin for users. This must be fixed before merging.
"eslint-plugin-prettier": "5.5.1", | ||
"ethers": "^6.14.1", | ||
"hardhat": "^2.0.4", | ||
"hardhat": "^3.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the hardhat
version in devDependencies
is updated, the peerDependencies
on line 86 remains "^2.0.4"
. This mismatch is critical for a major version bump. The peerDependencies
should be updated to be compatible with Hardhat v3, for instance "hardhat": "^3.0.0"
.
Note that this is a breaking change for the plugin's users, so the package version for @nomicfoundation/hardhat-verify
should likely be bumped to a new major version as well (e.g., 3.0.0
).
Snyk has created this PR to upgrade hardhat from 2.26.3 to 3.0.1.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 36 versions ahead of your current version.
The recommended version was released 21 days ago.
Issues fixed by the recommended upgrade:
SNYK-JS-COOKIE-8163060
SNYK-JS-TMP-11501554
Release notes
Package name: hardhat
This release adds
rpc
utils that are used from Hardhat.Changes
rpc
utils can be loaded (#7415)Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: